Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consolidate attestation functionality for issuer and verifier #1544

Merged

Conversation

aholovko
Copy link
Contributor

@aholovko aholovko commented Dec 4, 2023

No description provided.

Signed-off-by: Andrii Holovko <andriy.holovko@gmail.com>
@cla-bot cla-bot bot added the cla-signed label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3680bec) 85.58% compared to head (b3c74a9) 85.56%.

Files Patch % Lines
...ce/clientattestation/client_attestation_service.go 88.46% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
- Coverage   85.58%   85.56%   -0.03%     
==========================================
  Files         171      170       -1     
  Lines       11012    11019       +7     
==========================================
+ Hits         9425     9428       +3     
- Misses       1141     1143       +2     
- Partials      446      448       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit f1e194d into trustbloc:main Dec 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants