feat: [OIDC4VP] Verifier interaction with Trust registry #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
=======================================
Coverage 85.55% 85.56%
=======================================
Files 171 171
Lines 10988 11005 +17
=======================================
+ Hits 9401 9416 +15
- Misses 1141 1142 +1
- Partials 446 447 +1 ☔ View full report in Codecov by Sentry. |
b861345 to
5b120c3
Compare
Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com>
5b120c3 to
019ec88
Compare
aholovko
approved these changes
Nov 29, 2023
bstasyszyn
reviewed
Nov 29, 2023
|
|
||
| type CredentialMetadata struct { | ||
| CredentialID string `json:"credential_id"` | ||
| Types []string `json:"types"` |
There was a problem hiding this comment.
Should this be credential_types, issuer_id, issuance_date, and expiration_date?
There was a problem hiding this comment.
correct. Will update on next iteration.
bstasyszyn
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.