Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: claims keys concurrency #1461

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Oct 5, 2023

fatal error: concurrent map writes

goroutine 26200 [running]:
github.com/trustbloc/vcs/pkg/service/verifypresentation.(*Service).checkCredentialStrict(0xc00015b9c0, {0x2028368, 0xc005c7a810}, {0xc000302ba0, 0x1, 0xc003d39c40?})
/go/src/github.com/trustbloc/vcs/.build/vcs/pkg/service/verifypresentation/verifypresentation_service.go:205 +0x1f7
github.com/trustbloc/vcs/pkg/service/verifypresentation.(*Service).VerifyPresentation(0xc00015b9c0, {0x2028368, 0xc005c7a810}, 0xc007628f20, 0x0?, 0xc0072562c0)

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2023
@skynet2 skynet2 requested review from vkubiv and fqutishat October 5, 2023 22:14
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d3244d0) 85.40% compared to head (ae8aaf8) 85.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         164      164           
  Lines       10272    10267    -5     
=======================================
- Hits         8773     8769    -4     
+ Misses       1094     1092    -2     
- Partials      405      406    +1     
Files Coverage Δ
pkg/restapi/v1/verifier/controller.go 92.25% <100.00%> (ø)
pkg/service/oidc4vp/oidc4vp_service.go 89.93% <100.00%> (ø)
...e/verifypresentation/verifypresentation_service.go 83.85% <81.81%> (-0.09%) ⬇️
...s/verifypresentation/verifypresentation_wrapper.go 75.00% <62.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit 546b012 into trustbloc:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants