Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: params for oauth client manager #1414

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

aholovko
Copy link
Contributor

This PR fixes the following issues:

  • OAuth client manager uses values for grant_types_supported, response_types_supported and token_endpoint_auth_methods_supported from issuer's profile (OIDCConfig property). It's wrong as these values are supposed to be used when making calls to issuer's OIDC provider. VCS acts as an OIDC provider as well (e.g. for wallet) but it should use its own values here depending on what is actually implemented and supported (e.g. for grant_type only authorization_code and urn:ietf:params:oauth:grant-type:pre-authorized_code are supported).
  • Support for client secret expiration is not implemented properly (i.e. it doesn't make sense to issue client ID with secret that will expire in 5 min) - so, for now, proposal is to create clients with secrets that never expire.

Signed-off-by: Andrii Holovko <andriy.holovko@gmail.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (c64c6af) 85.35% compared to head (abe113a) 85.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
+ Coverage   85.35%   85.40%   +0.05%     
==========================================
  Files         162      162              
  Lines       10234    10222      -12     
==========================================
- Hits         8735     8730       -5     
+ Misses       1092     1088       -4     
+ Partials      407      404       -3     
Files Changed Coverage Δ
pkg/restapi/v1/oidc4ci/controller.go 90.05% <100.00%> (ø)
pkg/service/clientmanager/client_manager.go 95.65% <100.00%> (+4.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit 693c498 into trustbloc:main Sep 12, 2023
@aholovko aholovko deleted the fix_oauth_client_manager_params branch September 12, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants