Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate issuer claims against JSON schema #1381

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

bstasyszyn
Copy link
Contributor

Added a JSON schema field to the credentialTemplate profile element. If the "jsonSchema" field is not empty then the issuer claims are validated against the schema.

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 94.59% and project coverage change: +0.19% 🎉

Comparison is base (b97340f) 87.54% compared to head (a0df8b0) 87.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1381      +/-   ##
==========================================
+ Coverage   87.54%   87.74%   +0.19%     
==========================================
  Files         154      154              
  Lines        9266     9301      +35     
==========================================
+ Hits         8112     8161      +49     
+ Misses        763      747      -16     
- Partials      391      393       +2     
Files Changed Coverage Δ
pkg/restapi/v1/issuer/controller.go 93.00% <94.59%> (+4.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added a JSON schema field to the credentialTemplate profile element. If the "jsonSchema" field is not empty then the issuer claims are validated against the schema.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@fqutishat fqutishat merged commit f3207e9 into trustbloc:main Aug 18, 2023
@bstasyszyn bstasyszyn deleted the 11935 branch August 18, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants