feat: support for wallet initiated flow #1370

skynet2 · 2023-07-17T10:37:04Z

No description provided.

… flow Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com>

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

…llet_flow

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

codecov · 2023-07-17T14:57:56Z

Codecov Report

Patch coverage: 96.81% and project coverage change: -0.09 ⚠️

Comparison is base (965db5a) 87.54% compared to head (19e03b5) 87.46%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
- Coverage   87.54%   87.46%   -0.09%     
==========================================
  Files         149      153       +4     
  Lines        9040     9172     +132     
==========================================
+ Hits         7914     8022     +108     
- Misses        739      760      +21     
- Partials      387      390       +3

Impacted Files	Coverage Δ
pkg/restapi/v1/common/common.go	`100.00% <ø> (ø)`
pkg/restapi/v1/oidc4ci/controller.go	`90.65% <92.30%> (-0.34%)`	⬇️
pkg/service/oidc4ci/oidc4ci_service.go	`94.60% <95.23%> (-0.64%)`	⬇️
...bility/tracing/wrappers/oidc4ci/oidc4ci_wrapper.go	`85.71% <100.00%> (ø)`
pkg/restapi/v1/issuer/controller.go	`88.91% <100.00%> (+0.11%)`	⬆️
pkg/restapi/v1/util/validate.go	`100.00% <100.00%> (ø)`
...g/service/oidc4ci/oidc4ci_service_exchange_code.go	`100.00% <100.00%> (ø)`
...rvice/oidc4ci/oidc4ci_service_initiate_issuance.go	`92.77% <100.00%> (+0.16%)`	⬆️
...service/oidc4ci/oidc4ci_service_store_auth_code.go	`100.00% <100.00%> (ø)`
pkg/service/oidc4ci/regex.go	`100.00% <100.00%> (ø)`
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go

docs/v1/openapi.yaml

pkg/restapi/v1/util/validate.go

pkg/restapi/v1/util/validate_test.go

pkg/service/oidc4ci/oidc4ci_service.go

pkg/service/oidc4ci/oidc4ci_service_store_auth_code.go

DRK3

See comments

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go

pkg/restapi/v1/common/openapi.gen.go

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

sudeshrshetty · 2023-07-18T18:20:04Z

pkg/service/oidc4ci/regex.go

+package oidc4ci
+
+const (
+	WalletInitFlowClaimRegex              = `(https|http):\/\/.*\/issuer\/(.*?)\/(.*)$`


why we have this regex?

one of the scopes which we receive /odic/authorize endpoint is link to our issuer profile. this regex is used to identify that scope and parse it @sudeshrshetty

we just need to check if it URL or not, issuer term should be removed

test/bdd/fixtures/oauth-clients/clients.json

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go

Co-authored-by: Derek Trider <derektrider@gmail.com>

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

mishasizov-SK and others added 2 commits July 14, 2023 21:23

feat: OIDC4VCI Authorization code flow - Support for Wallet Initiated…

ca93627

… flow Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com>

chore: use only issuer url

f066e1a

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

cla-bot bot added the cla-signed label Jul 17, 2023

skynet2 added 10 commits July 17, 2023 13:42

refactor: wallet flow

40cee43

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

feat: more changes

3d2c716

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

chore: nullable

875f778

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

fix: build

f3d41c4

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

feat: more cleanup

4bae85e

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

fix: more lint

d0ff573

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

fix: unit

7b2888f

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

fix: test

ebe1c8d

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

Merge remote-tracking branch 'trustbloc/main' into feature/oidc4ci_wa…

3d7a038

…llet_flow

feat: more coverage

e2c0c9b

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

feat: improve codecov

cb7c421

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

skynet2 marked this pull request as ready for review July 18, 2023 13:42

skynet2 requested review from fqutishat, sudeshrshetty and DRK3 July 18, 2023 13:43

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

docs/v1/openapi.yaml Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

pkg/restapi/v1/util/validate.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

pkg/restapi/v1/util/validate_test.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

pkg/service/oidc4ci/oidc4ci_service.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

pkg/service/oidc4ci/oidc4ci_service_store_auth_code.go Outdated Show resolved Hide resolved

DRK3 reviewed Jul 18, 2023

View reviewed changes

pkg/service/oidc4ci/oidc4ci_service_store_auth_code.go Outdated Show resolved Hide resolved

DRK3 requested changes Jul 18, 2023

View reviewed changes

sudeshrshetty reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

pkg/restapi/v1/common/openapi.gen.go Show resolved Hide resolved

fix: comments

969ac60

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

skynet2 requested a review from DRK3 July 18, 2023 15:38

fix: test

abc9b55

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

skynet2 requested a review from sudeshrshetty July 18, 2023 16:02

skynet2 added 4 commits July 18, 2023 18:06

chore: openapigen

3e9a980

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

fix: auth flow bdd

94b6f44

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

chore: increase time

1be8b91

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

feat: add reset

c1e38ff

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

sudeshrshetty reviewed Jul 18, 2023

View reviewed changes

test/bdd/fixtures/oauth-clients/clients.json Show resolved Hide resolved

chore: make issuer state optional

4629da3

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

DRK3 approved these changes Jul 18, 2023

View reviewed changes

DRK3 reviewed Jul 18, 2023

View reviewed changes

component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go Outdated Show resolved Hide resolved

skynet2 and others added 3 commits July 18, 2023 21:12

Update component/wallet-cli/pkg/walletrunner/wallet_runner_oidc4ci.go

00a6c53

Co-authored-by: Derek Trider <derektrider@gmail.com>

fix: compile

b1466ca

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

feat: validate url only

19e03b5

Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>

sudeshrshetty approved these changes Jul 18, 2023

View reviewed changes

sudeshrshetty merged commit fee7f49 into trustbloc:main Jul 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support for wallet initiated flow #1370

feat: support for wallet initiated flow #1370

skynet2 commented Jul 17, 2023

codecov bot commented Jul 17, 2023 •

edited

Loading

DRK3 left a comment

sudeshrshetty Jul 18, 2023

skynet2 Jul 18, 2023

sudeshrshetty Jul 18, 2023

feat: support for wallet initiated flow #1370

feat: support for wallet initiated flow #1370

Conversation

skynet2 commented Jul 17, 2023

codecov bot commented Jul 17, 2023 • edited Loading

Codecov Report

DRK3 left a comment

Choose a reason for hiding this comment

sudeshrshetty Jul 18, 2023

Choose a reason for hiding this comment

skynet2 Jul 18, 2023

Choose a reason for hiding this comment

sudeshrshetty Jul 18, 2023

Choose a reason for hiding this comment

codecov bot commented Jul 17, 2023 •

edited

Loading