Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic client registration (part 2) #1336

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

aholovko
Copy link
Contributor

@aholovko aholovko commented Jun 13, 2023

This PR updates client manager with validation logic and adds support for additional client metadata fields.

@cla-bot cla-bot bot added the cla-signed label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 90.68% and project coverage change: +0.07 🎉

Comparison is base (d5a28bf) 87.34% compared to head (1b5b5c8) 87.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   87.34%   87.42%   +0.07%     
==========================================
  Files         148      149       +1     
  Lines        8774     8931     +157     
==========================================
+ Hits         7664     7808     +144     
- Misses        729      736       +7     
- Partials      381      387       +6     
Impacted Files Coverage Δ
pkg/restapi/v1/issuer/controller.go 88.64% <86.04%> (-0.62%) ⬇️
pkg/service/clientmanager/client_manager.go 90.51% <90.51%> (ø)
cmd/vc-rest/startcmd/oauth_provider.go 97.61% <100.00%> (ø)
cmd/vc-rest/startcmd/start.go 80.50% <100.00%> (+0.15%) ⬆️
component/oidc/fosite/mongo/client.go 100.00% <100.00%> (ø)
component/oidc/fosite/redis/store.go 100.00% <100.00%> (ø)
pkg/restapi/v1/oidc4ci/controller.go 90.97% <100.00%> (+0.16%) ⬆️
pkg/service/clientmanager/api.go 100.00% <100.00%> (ø)
...rvice/oidc4ci/oidc4ci_service_initiate_issuance.go 92.02% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aholovko aholovko force-pushed the dynamic-client-registration-2 branch from 976a55c to f9c5794 Compare June 13, 2023 19:10
@aholovko aholovko force-pushed the dynamic-client-registration-2 branch 2 times, most recently from 2b356a9 to 72d31d2 Compare June 15, 2023 12:04
@fqutishat fqutishat requested a review from sudeshrshetty June 15, 2023 12:20
@aholovko aholovko force-pushed the dynamic-client-registration-2 branch from 72d31d2 to 4ba7eb7 Compare June 15, 2023 12:38
Signed-off-by: Andrii Holovko <andriy.holovko@gmail.com>
@aholovko aholovko force-pushed the dynamic-client-registration-2 branch from 4ba7eb7 to 1b5b5c8 Compare June 15, 2023 14:34
@aholovko aholovko merged commit fc5fc49 into trustbloc:main Jun 15, 2023
@aholovko aholovko deleted the dynamic-client-registration-2 branch June 15, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants