Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional labels for metrics #1335

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Jun 13, 2023

skynet2 added 2 commits June 13, 2023 14:27
Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>
Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jun 13, 2023
Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>
@skynet2 skynet2 requested review from aholovko and fqutishat June 13, 2023 13:05
Signed-off-by: Stas D <stanislav.dmytryshyn@securekey.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 89.65% and no project coverage change.

Comparison is base (575d7b8) 87.31% compared to head (5554f66) 87.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   87.31%   87.32%           
=======================================
  Files         148      148           
  Lines        8724     8754   +30     
=======================================
+ Hits         7617     7644   +27     
- Misses        726      729    +3     
  Partials      381      381           
Impacted Files Coverage Δ
cmd/vc-rest/startcmd/start.go 80.34% <25.00%> (-0.33%) ⬇️
pkg/observability/metrics/prometheus/provider.go 92.13% <100.00%> (+1.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fqutishat fqutishat merged commit cc17619 into trustbloc:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants