ClientFilestore: make the dat folder optional
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c1f9b5 to
dd7836a
Compare
robin-nitrokey
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Maybe it would make sense to also have this distinction in the type system in the long term, e. g. use a RawClientFilestore type, or ScopedFilestore<Client>, ScopedFilestore<RawClient>, ...? I fear that the current implementation could lead to subtle bugs when the wrong constructor is used.
|
In the future yes. But not until we remove the configuration from the trussed-auth and se050 backends. Otherwise we can't just change the constructor based on the config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows custom backends to improve their storage, reducing the number of required intermediary directories.