Add support for interrupt #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce code duplication
The Responder never actually dealt with the intermediary stages of CancelingRequested and CancelingBuildingResponse, but could still observe them. Despite that, the loom tests still don't reach any panic
The first ordering of no operation relies on SeqCst semantics. All works with Acquire/Release semantics, so there is no reason to use the SeqCst ordering. The second ordering argument is for the failure, in which case we don't read any data, and therefore don't need any synchronization.
a378424 to
8601047
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: trussed-dev/trussed#124
This PR contains a bit more than just the added Interrupt method on the channel:
respondimplementation:Since the check of
State::BuildingResponse == self.channel.state.load(Ordering::Acquire)was distinct from theself.channel.state.store(State::Responded, …), the request could be cancelled while the response was written. a3cad6d adds the fix and updatestests/loom.rsto trigger this case.transitionmethod.The first ordering of no operation relies on SeqCst semantics.
All works with Acquire/Release semantics, so there is no reason to use the SeqCst ordering.
The second ordering argument is for the failure, in which case we don't read any data,
and therefore don't need any synchronization.