Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using Flutter 3 #604

Closed
amenk opened this issue Jul 3, 2022 · 4 comments
Closed

Allow using Flutter 3 #604

amenk opened this issue Jul 3, 2022 · 4 comments

Comments

@amenk
Copy link
Contributor

amenk commented Jul 3, 2022

In the long run, the package / example app should work with flutter 3.

Currently there seem to be build problems.
@amenk
Copy link
Contributor Author

amenk commented Sep 3, 2022 •
edited
Loading

Looks like we have MenuItem class, which Flutter 3 also ships. I am renaming our MenuItem to TrufiMenuItem

Now the only error left is:

Note: /home/user/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/app_review-2.1.2+1/android/src/main/java/com/appleeducate/appreview/AppReviewPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
e: /home/user/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/share_plus-3.1.0/android/src/main/kotlin/dev/fluttercommunity/plus/share/MethodCallHandler.kt: (34, 24): Type mismatch: inferred type is String? but String was expected

FAILURE: Build failed with an exception.

@amenk
Copy link
Contributor Author

amenk commented Sep 3, 2022

it's because of an outdated share_plus package ... bumping to 4.0.10+1

and it builds :-) 🎉

@amenk
Copy link
Contributor Author

amenk commented Sep 3, 2022 •
edited
Loading

Remaining known issue:

Note: /home/user/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/uni_links-0.5.1/android/src/main/java/name/avioli/unilinks/UniLinksPlugin.java uses or overrides a deprecated API.

But there is no more recent version for this package

amenk added a commit to AddisMap/trufi-core that referenced this issue Sep 3, 2022
@amenk
trufi-association#604 Ensure Compatibility with Flutter v3 (TrufiMenu…
11e527d 
…Item, Bump share_plus)

* menu_item.dart was renamed to trufi_menu_item.dart as well as the contained class (MenuItem->TrufiMenuItem).

* import last recent version of share_plus to fix build errors

The example now builds with Flutter 3
SamuelRioTz pushed a commit that referenced this issue Sep 18, 2022
@amenk
#604 Ensure Compatibility with Flutter v3 (TrufiMenuItem, Bump share_…
91f9bde 
…plus) (#627)

* menu_item.dart was renamed to trufi_menu_item.dart as well as the contained class (MenuItem->TrufiMenuItem).

* import last recent version of share_plus to fix build errors

The example now builds with Flutter 3
SamuelRioTz added a commit that referenced this issue Oct 1, 2022
@SamuelRioTz @amenk @GustavoTCh
release (#636)
d2fd72c 
* README: Fix logo, add links to YeneGuzo, adapt copyright year (#606)

* Fix Typos in constants / classes: Leaflet Map (#603)

* Feat/map provider service (#608)

* [Feature] remove GoogleMaps

* [Fix] resolved initHiveForFlutter

* [Feature] update pubspec.lock autogenerate files

* [Feature] update ext.kotlin_version lastest

* [Feature] update ios autogenerate files

* [Feat] param trufiMapProvider in default values

* [Fix] expanded ui map

* [Cleanup] ignore: deprecated_member_use for lunch

* [Feat] add versions to readme in Example (#625)

* Feat/Trufi-Core 3.2.0 stable (#629)

* [Fixed] CertificatedLetsencrypt android <= 7.1.1

* [feature] unusing certified ssl in web

* [Feature] config uni-link

* [Feature] share route button

* [Feature] share itinerary

* [Feature] use correct route

* [Feature] add google_maps_flutter ^2.1.4 package

* [Faeture] support widget marker in googleMaps

* [Feature] support other maps providers

* [Refactor] remove double cacheTileProvider

* [Feature] implement google and leaflet map route

* [Feature] implement leaflet=google map transport

* [Feat] implement leaflet=google map chooseLocation

* [Feature] use MapProviders in TrufiCore

* [Cleanup] remove un used files

* [Feature] using TrufiLatLng in all code

* [Refactor] move map buttons

* [feature] move marker configuration

* [Feature] update package to version: 3.1.0

* [Feature] correct size yourlocation in google map

* [Feature] add method to trufiLatLng

* [Feature] update version

* [Feature] update name Microbus

* [Feature] improve ui

* [Feature] create abstracts class for maps

* [Feature] hide share buttons

* [Fixed] use correct server

* [Feature] onReady map in leaflet

* [FIxed] clean lint

* [Feature] use minSdkVersion default

* [Feat] update feedbackTitle

* [Feat] add whatsappIcon

* [Feat] add bottomPaddingButtons in leaftle map

* [Feature] autogenerate files

* [Feat] update maps

* [Feature] remove google map

* [Feature] clean value

* [Feature] comment ios 9.0

* [Feature] refactor code

* [Cleanup] fix linter

* [Feature] add CertificatedLetsencryptAndroid

* [Feature] parameterize share base uri

* [Feature] configure shareBaseUri for example

* [Feature] update version to  trufi-core _v3.2.0

* [Feature] configure url_launcher ios

* [Fixed] resolve error in package device_info_plus

* [Feat] parameterize RequestPlanService in blocProviders

* [Fix] use correct routeColor

* [Fix] remove duplication MapRouteCubit

* [Fix] error code color

* [Fix] correct color leaftlet map route

* [Fix] resolve overFlowed when per > 1

* [Feat] Create AppUniqueId for session

* [Feat] Add UniqueAppId in Requests and Queries

* [Cleanup] Remove unused code

* #604 Ensure Compatibility with Flutter v3 (TrufiMenuItem, Bump share_plus) (#627)

* menu_item.dart was renamed to trufi_menu_item.dart as well as the contained class (MenuItem->TrufiMenuItem).

* import last recent version of share_plus to fix build errors

The example now builds with Flutter 3

* Feat/migration flutter 3.3.2 (#634)

* feat(trufi-core)!: Migrated flutter files to v3.3.2

* [Feat] updated packages to lastest version

* [Refactor] Updated sintaxis waring for  Flutter v3.3.2

* [Refactor] Updated sintaxis for FlutterMap_v3.0.0

* [Refactor] updated configure dependencies

* adding migration (#635)

Co-authored-by: Gustavo T <tgustavoch@gmail.com>

* fix flutter version (#637)

Co-authored-by: Gustavo T <tgustavoch@gmail.com>

* Fix/analyze issue (#638)

* fix flutter version

* adding fix

Co-authored-by: Gustavo T <tgustavoch@gmail.com>

Co-authored-by: Alexander Menk <alex@addismap.com>
Co-authored-by: Gustavo T <tgustavoch@gmail.com>
@SamuelRioTz SamuelRioTz mentioned this issue Oct 1, 2022
Merged
SamuelRioTz added a commit that referenced this issue Oct 1, 2022
@SamuelRioTz @amenk @GustavoTCh
release (#636) (#639)
bf10d0a 
* README: Fix logo, add links to YeneGuzo, adapt copyright year (#606)

* Fix Typos in constants / classes: Leaflet Map (#603)

* Feat/map provider service (#608)

* [Feature] remove GoogleMaps

* [Fix] resolved initHiveForFlutter

* [Feature] update pubspec.lock autogenerate files

* [Feature] update ext.kotlin_version lastest

* [Feature] update ios autogenerate files

* [Feat] param trufiMapProvider in default values

* [Fix] expanded ui map

* [Cleanup] ignore: deprecated_member_use for lunch

* [Feat] add versions to readme in Example (#625)

* Feat/Trufi-Core 3.2.0 stable (#629)

* [Fixed] CertificatedLetsencrypt android <= 7.1.1

* [feature] unusing certified ssl in web

* [Feature] config uni-link

* [Feature] share route button

* [Feature] share itinerary

* [Feature] use correct route

* [Feature] add google_maps_flutter ^2.1.4 package

* [Faeture] support widget marker in googleMaps

* [Feature] support other maps providers

* [Refactor] remove double cacheTileProvider

* [Feature] implement google and leaflet map route

* [Feature] implement leaflet=google map transport

* [Feat] implement leaflet=google map chooseLocation

* [Feature] use MapProviders in TrufiCore

* [Cleanup] remove un used files

* [Feature] using TrufiLatLng in all code

* [Refactor] move map buttons

* [feature] move marker configuration

* [Feature] update package to version: 3.1.0

* [Feature] correct size yourlocation in google map

* [Feature] add method to trufiLatLng

* [Feature] update version

* [Feature] update name Microbus

* [Feature] improve ui

* [Feature] create abstracts class for maps

* [Feature] hide share buttons

* [Fixed] use correct server

* [Feature] onReady map in leaflet

* [FIxed] clean lint

* [Feature] use minSdkVersion default

* [Feat] update feedbackTitle

* [Feat] add whatsappIcon

* [Feat] add bottomPaddingButtons in leaftle map

* [Feature] autogenerate files

* [Feat] update maps

* [Feature] remove google map

* [Feature] clean value

* [Feature] comment ios 9.0

* [Feature] refactor code

* [Cleanup] fix linter

* [Feature] add CertificatedLetsencryptAndroid

* [Feature] parameterize share base uri

* [Feature] configure shareBaseUri for example

* [Feature] update version to  trufi-core _v3.2.0

* [Feature] configure url_launcher ios

* [Fixed] resolve error in package device_info_plus

* [Feat] parameterize RequestPlanService in blocProviders

* [Fix] use correct routeColor

* [Fix] remove duplication MapRouteCubit

* [Fix] error code color

* [Fix] correct color leaftlet map route

* [Fix] resolve overFlowed when per > 1

* [Feat] Create AppUniqueId for session

* [Feat] Add UniqueAppId in Requests and Queries

* [Cleanup] Remove unused code

* #604 Ensure Compatibility with Flutter v3 (TrufiMenuItem, Bump share_plus) (#627)

* menu_item.dart was renamed to trufi_menu_item.dart as well as the contained class (MenuItem->TrufiMenuItem).

* import last recent version of share_plus to fix build errors

The example now builds with Flutter 3

* Feat/migration flutter 3.3.2 (#634)

* feat(trufi-core)!: Migrated flutter files to v3.3.2

* [Feat] updated packages to lastest version

* [Refactor] Updated sintaxis waring for  Flutter v3.3.2

* [Refactor] Updated sintaxis for FlutterMap_v3.0.0

* [Refactor] updated configure dependencies

* adding migration (#635)

Co-authored-by: Gustavo T <tgustavoch@gmail.com>

* fix flutter version (#637)

Co-authored-by: Gustavo T <tgustavoch@gmail.com>

* Fix/analyze issue (#638)

* fix flutter version

* adding fix

Co-authored-by: Gustavo T <tgustavoch@gmail.com>

Co-authored-by: Alexander Menk <alex@addismap.com>
Co-authored-by: Gustavo T <tgustavoch@gmail.com>

Co-authored-by: Alexander Menk <alex@addismap.com>
Co-authored-by: Gustavo T <tgustavoch@gmail.com>
@amenk amenk closed this as completed Oct 24, 2022
@amenk
Copy link
Contributor Author

amenk commented Oct 24, 2022

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amenk