This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Hook up truffle debug to @truffle/from-hardhat
#5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincburns
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
LGTM - pretty easy one to approve.
That said, this one could probably also use a test. I think unfortunately anything other than a scenario test would require a lot of additional refactoring.
Feel free to pile this onto #5442 if you'd like.
|
Thanks @benjamincburns! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #5420 and uses that PR's introduced @truffle/from-hardhat package to provide native Hardhat support for the
truffle debugcommand.