This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Gracelessly shove Hardhat support into truffle debug
#5410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Aug 9, 2022
| network_id: "*" | ||
| }; | ||
|
|
||
| require(`${config.working_directory}/node_modules/hardhat/register`); |
There was a problem hiding this comment.
Not needed if you import hardhat below
There was a problem hiding this comment.
I tried it without this and this line was necessary... I think I'm going to go with the approach of shelling out to node -r hardhat/register instead of this.
alcuadrado
reviewed
Aug 9, 2022
| artifacts | ||
| } = require(`${config.working_directory}/node_modules/hardhat`); | ||
| const buildInfoPaths = await artifacts.getBuildInfoPaths(); | ||
| const buildInfos = await Promise.all( |
There was a problem hiding this comment.
This will lead to an OOM. I'd read one build info at the time, as they can be huge. They have the entire solc output, so they can take 100mb+ in some large projects.
alcuadrado
reviewed
Aug 9, 2022
| const { _format } = buildInfo; | ||
|
|
||
| if (!supportedFormats.has(_format)) { | ||
| throw new Error(`Unsupported build info format: ${_format}`); |
There was a problem hiding this comment.
<3
It's great that you are validating this!
This was referenced Aug 10, 2022
|
I want this branch name back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip... this is a hack and a half