This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Put all BUNDLE globals in main .eslintrc.json #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
approved these changes
Feb 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What with @lsqproduction dealing with
BUNDLE_VERSIONin #4686, and @cds-amal dealing withBUNDLE_CHAIN_FILENAMEin #4671, I thought it was probably best to just take the whole list of these variables and stick them in the main.eslintrc.json, so we don't have to keep worrying about this (unless we add new ones of these!).(Hope you don't mind @cds-amal!)