Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bundle commands separately #3351

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

eggplantzzz
Copy link
Contributor

Split code shared by cli.js and console-child.js out into its own bundle

@fainashalts
Copy link
Contributor

@eggplantzzz thanks for putting this PR together! I'm on board with this approach, but command.bundled.js won't be available to unbundled versions of Truffle. I think we can probably just check whether a user is using the bundled version there.

@eggplantzzz
Copy link
Contributor Author

eggplantzzz commented Sep 9, 2020

I used BUNDLE_VERSION which is an environment variable we inject in the bundle.

@fainashalts
Copy link
Contributor

fainashalts commented Sep 9, 2020

Yes, true about users never having the unbundled versions, though I'd venture that its important for Truffle devs and community contributors to be able to use the unbundled version when needed. I guess I didn't mean actual users. This fix seems to address that just fine! This LGTM, pending tests passing.

@fainashalts fainashalts merged commit 334b42d into revert-3314-revert-3255-spawn-repl Sep 9, 2020
@fainashalts fainashalts deleted the bundle-split branch September 9, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants