Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Remove subcommands architecture and mentions for merging later #3328

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

fainashalts
Copy link
Contributor

This PR removes the subcommands architecture and related mentions, as we want the truffle-db branch to avoid affecting other packages when it is initially merged into develop.

@fainashalts fainashalts requested review from cds-amal and gnidan August 31, 2020 19:02
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this behaves differently than stable for test within truffle develop console. Both stable and starts the ganache provider on the same port. Stable executes tests and this branch cannot find the provider.

I think this might be related the yargs argument fix.

Apart from that issue it looks good.

@gnidan gnidan mentioned this pull request Sep 4, 2020
9 tasks
@fainashalts
Copy link
Contributor Author

Noting that this behaves differently than stable for test within truffle develop console. Both stable and starts the ganache provider on the same port. Stable executes tests and this branch cannot find the provider.

I think this might be related the yargs argument fix.

Apart from that issue it looks good.

@cds-amal did you mean this comment for this PR? The yargs fix is in the spawn-repl work #3319.

@cds-amal
Copy link
Member

cds-amal commented Sep 4, 2020

Noting that this behaves differently than stable for test within truffle develop console. Both stable and starts the ganache provider on the same port. Stable executes tests and this branch cannot find the provider.
I think this might be related the yargs argument fix.
Apart from that issue it looks good.

@cds-amal did you mean this comment for this PR? The yargs fix is in the spawn-repl work #3319.

Ah, thanks @fainashalts ! I don't think the issue I noted is related to this PR and is fixed up-branch.

@cds-amal cds-amal self-requested a review September 4, 2020 21:56
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @fainashalts !

@fainashalts fainashalts merged commit 9f818f9 into truffle-db Sep 8, 2020
@fainashalts fainashalts deleted the db-remove-subcommands branch September 8, 2020 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants