This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Convert bignumbers properly for forked fallback balance lookup #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update the test to make sure the balance isn't too large (which it was in this case) for #128
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with a change in how the balances were provided from web3. I believe that the original implementation was referencing https://github.com/ethereum/wiki/wiki/JavaScript-API#returns-33 instead of the newer version: https://web3js.readthedocs.io/en/1.0/web3-eth.html#getbalance
This PR also updates the test which checks the balance difference between forked chain and base chain. It tests to make sure the values are ~5% near each other. I think there is a better way to test this by creating a new test which doesn't have transactions and merely just checks the balance. This fix will address the problem for now however.
Fixes #128