Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - add comment to close BufferedReadSeeker #3622

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[chore] - add comment to close BufferedReadSeeker #3622

merged 1 commit into from
Nov 18, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 18, 2024

Description:

This PR updates the BufferedReadSeeker comment to clarify that the caller is responsible for closing the reader.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review November 18, 2024 22:25
@ahrav ahrav requested a review from a team as a code owner November 18, 2024 22:25
@ahrav ahrav requested review from a team November 18, 2024 22:25
@ahrav ahrav merged commit dfcce42 into main Nov 18, 2024
13 checks passed
@ahrav ahrav deleted the chore-update-bufferedreadseeker-doc-comment branch November 18, 2024 22:35
@blsaccess blsaccess mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @mcastorina