Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] - Close the BufferedReadSeekr after use #3618

Merged
merged 2 commits into from
Nov 18, 2024
Merged

[fix] - Close the BufferedReadSeekr after use #3618

merged 2 commits into from
Nov 18, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 18, 2024 •
edited
Loading

Description:

This PR ensures Close() is called on the BufferedReadSeeker after processing .apk archives.

Minor formatting changes were also included to get the linter off my back. (mainly line length)

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav requested review from joeleonjr and a team November 18, 2024 17:32
@ahrav ahrav marked this pull request as ready for review November 18, 2024 17:51
@ahrav ahrav requested a review from a team as a code owner November 18, 2024 17:51
joeleonjr
joeleonjr approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@joeleonjr joeleonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed scanning still works as expected. Changes look good. Great catch on closing that bufferedreadseekr.

@ahrav ahrav merged commit 908e742 into main Nov 18, 2024
13 checks passed
@ahrav ahrav deleted the fix-release-resources branch November 18, 2024 21:13
@blsaccess blsaccess mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

@joeleonjr joeleonjr joeleonjr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrav @mcastorina @joeleonjr