Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] - Manually upgrade Github dep #3387

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[chore] - Manually upgrade Github dep #3387

merged 1 commit into from
Oct 10, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Oct 9, 2024

Description:

Upgrade Github dependency.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review October 9, 2024 17:15
@ahrav ahrav requested review from a team as code owners October 9, 2024 17:15
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What prompted this?

@ahrav
Copy link
Collaborator Author

ahrav commented Oct 10, 2024

What prompted this?

Renovate struggles with go-github upgrades. It just adds the new version in the go.mod without updating any of the imports. I've been doing it manually the last 3 or so updates.

@ahrav ahrav merged commit e57c712 into main Oct 10, 2024
13 checks passed
@ahrav ahrav deleted the chore-update-github-dep branch October 10, 2024 13:16
@rgmz
Copy link
Contributor

rgmz commented Oct 10, 2024

The way they handle version changes is strange. I haven't seen any other package do something similar.

@ahrav
Copy link
Collaborator Author

ahrav commented Oct 10, 2024

The way they handle version changes is strange. I haven't seen any other package do something similar.

At one point, the go.mod had three different versions of the go-github dependency, even though only one was in use. 🤷‍♂️

abmussani added a commit to abmussani/trufflehog that referenced this pull request Oct 14, 2024
* main: (127 commits)
  Update SaladCloud description (trufflesecurity#3399)
  fix tests (trufflesecurity#3400)
  [chore] Update custom detector default description (trufflesecurity#3398)
  add description to salad (trufflesecurity#3397)
  Add detector for SaladCloud API Keys (trufflesecurity#3273)
  fix(deps): update module github.com/xanzy/go-gitlab to v0.111.0 (trufflesecurity#3393)
  Add SliceContainsString common util (trufflesecurity#3395)
  fix: pr template link to golangci-lint (trufflesecurity#3392)
  fix(deps): update golang.org/x/exp digest to f66d83c (trufflesecurity#3389)
  Separate detector tests into unit/integration (trufflesecurity#3274)
  Manually upgrade github dep (trufflesecurity#3387)
  Updated Fastly Personal Token Detector (trufflesecurity#3386)
  fix(deps): update module google.golang.org/api to v0.200.0 (trufflesecurity#3391)
  [Fix] Snowflake privatelink Support (trufflesecurity#3286)
  Enhanced the easyinsight detector (trufflesecurity#3384)
  Log skipped files on debug level (trufflesecurity#3383)
  build: update retracted bluemonday ver (trufflesecurity#3369)
  Fix git binary handling and add a smoke test (trufflesecurity#3379)
  fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382)
  Added Cisco Meraki API Key detector (trufflesecurity#3367)
  ...

# Conflicts:
#	pkg/engine/defaults.go
#	pkg/pb/detectorspb/detectors.pb.go
#	proto/detectors.proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants