Detect Slack workflows webhook #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
841c20f to
cd1d9c9
Compare
ahrav
reviewed
Apr 10, 2024
| keyPat = regexp.MustCompile(`(https://hooks\.slack\.com/services/T[A-Z0-9]+/B[A-Z0-9]+/[A-Za-z0-9]{23,25})`) | ||
| keyPats = map[string]*regexp.Regexp{ | ||
| "Slack Service Web Hook": regexp.MustCompile(`(https://hooks\.slack\.com/services/T[A-Z0-9]+/B[A-Z0-9]+/[A-Za-z0-9]{23,25})`), | ||
| "Slack Workflow Web Hook ": regexp.MustCompile(`(https://hooks\.slack\.com/workflows/T[A-Z0-9]+/A[A-Z0-9]+/[0-9]{17,19}/[A-Za-z0-9]{23,25})`), |
There was a problem hiding this comment.
question: I'm not intimately familiar with slack webhooks, but when I go into our slack to create a workflow the "Web request URL" I am getting looks like https://hooks.slack.com/triggers/TEL4..../69.../... Is this because Slack updated the format of the URL or i'm just setting it up in the wrong place.
There was a problem hiding this comment.
No you're right, this format seems to be a legacy one already.
There was a problem hiding this comment.
Great, thanks for confirming.
ahrav
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks a lot @juliendoutre for the update here, we really appreciate it! Sorry for the delayed review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the solution proposed in #2571 to detect another type of Slack Webhook URLs.
Checklist:
make test-community)?make lintthis requires golangci-lint)?