added onfleet api key detector #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
may i know why this PR was not added |
ahrav
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
Hey @ankushgoel27 sorry for the delayed review, I think we might've just missed this PR. I've added a test credential so the test suite passes.
Thanks again for the contribution, we really appreciate it. Apologies again for the delayed review.
| } | ||
|
|
||
| func verifyMatch(ctx context.Context, client *http.Client, token string) (bool, map[string]string, error) { | ||
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, "https://onfleet.com/api/v2/organization", nil) |
There was a problem hiding this comment.
Hope you don't mind but I updated this endpoint to use GET organization. docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the onfleet api key detector.
https://docs.onfleet.com/reference/introduction
Checklist:
make test-community)?make lintthis requires golangci-lint)?