add method for zero alloc byte slice to str

pkg/common/byteconv.go

@@ -0,0 +1,8 @@
+package common
+
+import "unsafe"
+
+// BytesToString converts a byte slice to a string without allocating.
+func BytesToString(b []byte) string {
+	return unsafe.String(unsafe.SliceData(b), len(b))
+}

pkg/common/byteconv_test.go

@@ -0,0 +1,77 @@
+package common
+
+import (
+	"math/rand"
+	"reflect"
+	"testing"
+	"testing/quick"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestBytesToString_IdentityProperty(t *testing.T) {
+	identityProperty := func(b []byte) bool {
+		return BytesToString(b) == string(b)
+	}
+
+	genRandBytes := func(size int) []byte {
+		b := make([]byte, size)
+
+		r := rand.New(rand.NewSource(time.Now().UnixNano()))
+		for i := 0; i < size; i++ {
+			b[i] = byte(r.Intn(256))
+		}
+
+		return b
+	}
+
+	cfg := &quick.Config{
+		Values: func(values []reflect.Value, rand *rand.Rand) {
+			// 2% chance to return a nil slice.
+			if rand.Intn(2) == 0 {
+				values[0] = reflect.Zero(reflect.TypeOf([]byte{}))
+				return
+			}
+			values[0] = reflect.ValueOf(genRandBytes(rand.Intn(100_000)))
+		},
+	}
+
+	assert.NoError(t, quick.Check(identityProperty, cfg))
+}
+
+func TestBytesToString_LengthProperty(t *testing.T) {
+	lengthProperty := func(b []byte) bool {
+		return len(BytesToString(b)) == len(b)
+	}
+
+	assert.NoError(t, quick.Check(lengthProperty, nil))
+}
+
+// TestBytesToString_SharedDataConsistency checks if mutating the input byte slice
+// after conversion affects the string output from BytesToString, testing that the
+// underlying data sharing between the slice and the string is handled correctly.
+func TestBytesToString_SharedDataConsistency(t *testing.T) {
+	immutabilityProperty := func(b []byte) bool {
+		if len(b) == 0 {
+			return BytesToString(b) == string(b)
+		}
+		s := BytesToString(b)
+		b[0] = 0 // modify byte slice
+		return s == BytesToString(b)
+	}
+
+	assert.NoError(t, quick.Check(immutabilityProperty, nil))
+}
+
+// TestBytesToString_ConsistencyProperty checks if BytesToString returns consistent
+// results for the same byte slice input, ensuring deterministic behavior.
+func TestBytesToString_ConsistencyProperty(t *testing.T) {
+	consistencyProperty := func(b []byte) bool {
+		s1 := BytesToString(b)
+		s2 := BytesToString(b)
+		return s1 == s2
+	}
+
+	assert.NoError(t, quick.Check(consistencyProperty, nil))
+}

pkg/custom_detectors/custom_detectors.go

@@ -8,11 +8,12 @@ import (
 	"regexp"
 	"strings"
 
+	"golang.org/x/sync/errgroup"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 	"github.com/trufflesecurity/trufflehog/v3/pkg/pb/custom_detectorspb"
 	"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detectorspb"
-	"golang.org/x/sync/errgroup"
 )
 
 // The maximum number of matches from one chunk. This const is used when
@@ -58,7 +59,7 @@ func NewWebhookCustomRegex(pb *custom_detectorspb.CustomRegex) (*CustomRegexWebh
 var httpClient = common.SaneHttpClient()
 
 func (c *CustomRegexWebhook) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 	regexMatches := make(map[string][][]string, len(c.GetRegex()))
 
 	// Find all submatches for each regex.

pkg/detectors/abbysale/abbysale.go

@@ -31,7 +31,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Abbysale secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/abbysale/abbysale_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/abstract/abstract.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Abstract secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/abuseipdb/abuseipdb.go

@@ -33,7 +33,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify AbuseIPDB secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/abuseipdb/abuseipdb_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/accuweather/accuweather.go

@@ -31,7 +31,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Accuweather secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/accuweather/accuweather_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/adafruitio/adafruitio.go

@@ -31,7 +31,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify AdafruitIO secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/adobeio/adobeio.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify AdobeIO secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 	idMatches := idPat.FindAllStringSubmatch(dataStr, -1)

pkg/detectors/adobeio/adobeio_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/adzuna/adzuna.go

@@ -33,7 +33,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Adzuna secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 	idMatches := idPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/adzuna/adzuna_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/aeroworkflow/aeroworkflow.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Aeroworkflow secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 	idmatches := idPat.FindAllStringSubmatch(dataStr, -1)

pkg/detectors/agora/agora.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Agora secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 	secretMatches := secretPat.FindAllStringSubmatch(dataStr, -1)

pkg/detectors/agora/agora_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/aha/aha.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Aha secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/airbrakeprojectkey/airbrakeprojectkey.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify AirbrakeProjectKey secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 	idMatches := idPat.FindAllStringSubmatch(dataStr, -1)

pkg/detectors/airbrakeprojectkey/airbrakeprojectkey_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/airbrakeuserkey/airbrakeuserkey.go

@@ -31,7 +31,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify AirbrakeUserKey secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/airbrakeuserkey/airbrakeuserkey_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/airship/airship.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Airship secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/airship/airship_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/airtableapikey/airtableapikey.go

@@ -41,7 +41,7 @@ type response struct {
 
 // FromData will find and optionally verify AirtableApiKey secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	appMatches := appPat.FindAllStringSubmatch(dataStr, -1)
 	keyMatches := keyPat.FindAllStringSubmatch(dataStr, -1)

pkg/detectors/airtableapikey/airtableapikey_test.go

@@ -13,6 +13,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"
 	"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detectorspb"
 )

pkg/detectors/airvisual/airvisual.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify AirVisual secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/airvisual/airvisual_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/aiven/aiven.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Aiven secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/aiven/aiven_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/alchemy/alchemy.go

@@ -33,7 +33,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Alchemy secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/alchemy/alchemy_test.go

@@ -6,11 +6,12 @@ package alchemy
 import (
 	"context"
 	"fmt"
-	"github.com/google/go-cmp/cmp"
-	"github.com/google/go-cmp/cmp/cmpopts"
 	"testing"
 	"time"
 
+	"github.com/google/go-cmp/cmp"
+	"github.com/google/go-cmp/cmp/cmpopts"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/alconost/alconost.go

@@ -33,7 +33,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Alconost secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 

pkg/detectors/alconost/alconost_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kylelemons/godebug/pretty"
+
 	"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"

pkg/detectors/alegra/alegra.go

@@ -32,7 +32,7 @@ func (s Scanner) Keywords() []string {
 
 // FromData will find and optionally verify Alegra secrets in a given set of bytes.
 func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
-	dataStr := string(data)
+	dataStr := common.BytesToString(data)
 
 	matches := keyPat.FindAllStringSubmatch(dataStr, -1)
 	idMatches := idPat.FindAllStringSubmatch(dataStr, -1)