Add test case to gitparse that previously caused a panic #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and the #1570 fix handles this. It looked to me like it shouldn't miss anything at first glance. If |
mcastorina
approved these changes
Jan 26, 2024
Comment on lines
+17
to
+18
| //go:embed testdata/panic_diff_1.txt | ||
| panicDiff1 []byte |
There was a problem hiding this comment.
Cool, I didn't know you could do this!
Comment on lines
+33
to
+38
| // setup logger | ||
| logger, sync := log.New("forager/scanner", | ||
| log.WithConsoleSink(os.Stderr), | ||
| ) | ||
| defer func() { _ = sync() }() | ||
| context.SetDefaultLogger(logger) |
There was a problem hiding this comment.
This log setup can probably be removed - we now have a default global logger that will be used from context.Background().
| ctx := context.Background() | ||
| parser := NewParser() | ||
| commitCh := make(chan Commit, 64) | ||
| parser.FromReader(ctx, io.NopCloser(bytes.NewReader(panicDiff1)), commitCh, false) |
There was a problem hiding this comment.
Is the idea of this test that this line won't panic? What do you think about using assert.NotPanics to make that explicit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case to gitparse that caused a panic which was fixed by #1570