NAS-133680 / 25.10 / Disable SMB2 lease support in multiprotocol SMB mode #15740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables SMB2/3 lease support globally when multiprotocol SMB shares are enabled. This is because despite kernel_oplocks being a per-share parameter in libsmbconf, it is incompatible with SMB2/3 lease support and can lead to unexpected failures depending on the order in which the SMB client has negotiated its first SMB tree connect. Validation logic is simplified by making this share type mutually exclusive with AAPL extension support because timemachine -- the main driver for enabling this -- requires SMB2/3 lease support.
yocalebo
reviewed
Feb 17, 2025
yocalebo
approved these changes
Feb 17, 2025
Co-authored-by: Caleb St. John <30729806+yocalebo@users.noreply.github.com>
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables SMB2/3 lease support globally when multiprotocol SMB shares are enabled. This is because despite kernel_oplocks being a per-share parameter in libsmbconf, it is incompatible with SMB2/3 lease support and can lead to unexpected failures depending on the order in which the SMB client has negotiated its first SMB tree connect.
Validation logic is simplified by making this share type mutually exclusive with AAPL extension support because timemachine -- the main driver for enabling this -- requires SMB2/3 lease support.