Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate(splunk): Migrate to new common #15093

Merged
merged 20 commits into from
Nov 23, 2023
Merged

migrate(splunk): Migrate to new common #15093

merged 20 commits into from
Nov 23, 2023

Conversation

atanaspam
Copy link
Contributor

Description

⚒️ Fixes #15091

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@atanaspam atanaspam requested review from PrivatePuffin and a team as code owners November 19, 2023 00:25
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2023

CLA assistant check
All committers have signed the CLA.

@atanaspam atanaspam marked this pull request as draft November 19, 2023 00:51
@atanaspam atanaspam marked this pull request as ready for review November 20, 2023 00:26
charts/incubator/splunk/values.yaml Outdated Show resolved Hide resolved
atanaspam and others added 4 commits November 23, 2023 15:42
Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com>
Signed-off-by: Atanas Pamukchiev <atanaspam@users.noreply.github.com>
Copy link
Collaborator

@xstar97 xstar97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update appVersion: "9.0.4" to appVersion: "9.1.2"

charts/incubator/splunk/values.yaml Outdated Show resolved Hide resolved
@xstar97 xstar97 enabled auto-merge (squash) November 23, 2023 21:31
@xstar97 xstar97 merged commit 015ec33 into truecharts:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splunk chart uses non-existent middleware
4 participants