feat(db/trans-cache): verify cached files with crc32c #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## release_v4.7.3 #5523 +/- ##
====================================================
+ Coverage 64.99% 65.20% +0.20%
- Complexity 10020 10056 +36
====================================================
Files 894 894
Lines 53816 53847 +31
Branches 5926 5929 +3
====================================================
+ Hits 34979 35112 +133
+ Misses 16123 16019 -104
- Partials 2714 2716 +2
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tomatoishealthy
approved these changes
Oct 7, 2023
jwrct
approved these changes
Oct 8, 2023
lurais
reviewed
Oct 8, 2023
| @@ -288,6 +295,7 @@ private boolean recovery() { | |||
| } | |||
|
|
|||
| private boolean recovery(int index, Path file) { | |||
| checkCrc32c(index, file); | |||
There was a problem hiding this comment.
Has this error happened in tests? Why will it happen? Will some error info printed when this kind of errors be found?
There was a problem hiding this comment.
To catch accidents like disk write errors, service crash etc.
Will some error info printed when this kind of errors be found?
Yes, there will be an exception.
tomatoishealthy
approved these changes
Oct 8, 2023
jwrct
approved these changes
Oct 8, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CRC32 to catch accidents like disk write errors, etc.