Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): optimize checking logic of SyncBlockChainMessage #5097

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

xxo1shine
Copy link
Contributor

@xxo1shine xxo1shine commented Mar 29, 2023

What does this PR do?
optimize checking logic of SyncBlockChainMessage

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #5097 (2fd5fbe) into release_v4.7.2 (2b7588c) will increase coverage by 0.04%.
The diff coverage is 42.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5097      +/-   ##
====================================================
+ Coverage             54.75%   54.80%   +0.04%     
- Complexity             8244     8255      +11     
====================================================
  Files                   842      842              
  Lines                 49753    49757       +4     
  Branches               5470     5471       +1     
====================================================
+ Hits                  27242    27267      +25     
+ Misses                20368    20349      -19     
+ Partials               2143     2141       -2     
Impacted Files Coverage Δ
...e/net/messagehandler/SyncBlockChainMsgHandler.java 17.85% <42.85%> (+8.24%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxo1shine xxo1shine changed the title feat(net): optimize sync block chain message check logic feat(net): optimize checking logic of SyncBlockChainMessage Mar 29, 2023
@xxo1shine xxo1shine merged commit 415dc52 into tronprotocol:release_v4.7.2 Mar 29, 2023
@xxo1shine xxo1shine deleted the opt_sync_check branch July 14, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants