Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): optimize the judgement of node type #4986

Merged

Conversation

halibobo1205
Copy link
Contributor

@halibobo1205 halibobo1205 commented Feb 13, 2023

What does this PR do?
optimize the judgement of node type, full node or lite node
Why are these changes required?

fix some unreasonable judgment logic in some specific scenarios, previous PR: #4323

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 force-pushed the feat/lite_node branch 2 times, most recently from d27c40b to 92cf78a Compare February 13, 2023 06:16
@halibobo1205 halibobo1205 changed the title feat(db): optimize the judgment of node type feat(db): optimize the judgement of node type Feb 13, 2023
@halibobo1205 halibobo1205 changed the base branch from develop to release_v4.7.1 February 13, 2023 06:17
@codecov-commenter
Copy link

Codecov Report

Merging #4986 (92cf78a) into release_v4.7.1 (50ad05a) will decrease coverage by 0.02%.
The diff coverage is 76.47%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.1    #4986      +/-   ##
====================================================
- Coverage             54.70%   54.69%   -0.02%     
- Complexity             8220     8224       +4     
====================================================
  Files                   841      841              
  Lines                 49702    49679      -23     
  Branches               5456     5452       -4     
====================================================
- Hits                  27191    27172      -19     
  Misses                20369    20369              
+ Partials               2142     2138       -4     
Impacted Files Coverage Δ
...se/src/main/java/org/tron/core/db/CommonStore.java 37.50% <ø> (-50.00%) ⬇️
...ava/org/tron/common/parameter/CommonParameter.java 55.01% <ø> (ø)
.../tron/core/net/message/handshake/HelloMessage.java 0.00% <0.00%> (ø)
...on/core/services/filter/LiteFnQueryHttpFilter.java 96.34% <0.00%> (-1.22%) ⬇️
...a/org/tron/tool/litefullnode/LiteFullNodeTool.java 75.47% <ø> (-0.45%) ⬇️
...ase/src/main/java/org/tron/core/db/BlockStore.java 90.90% <100.00%> (+4.24%) ⬆️
.../src/main/java/org/tron/core/config/args/Args.java 59.96% <100.00%> (+0.05%) ⬆️
...mework/src/main/java/org/tron/core/db/Manager.java 53.08% <100.00%> (-0.01%) ⬇️
...re/services/filter/LiteFnQueryGrpcInterceptor.java 96.49% <100.00%> (+1.75%) ⬆️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halibobo1205 halibobo1205 force-pushed the feat/lite_node branch 2 times, most recently from 619c755 to 57ec5f9 Compare February 13, 2023 09:55
@halibobo1205 halibobo1205 merged commit 1450156 into tronprotocol:release_v4.7.1 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants