Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func(proposal,chainid): optimize the return value of chainid #4863

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

yanghang8612
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #4863 (716ab53) into release_v4.7.0 (eb0065c) will decrease coverage by 0.15%.
The diff coverage is 70.73%.

@@                 Coverage Diff                  @@
##             release_v4.7.0    #4863      +/-   ##
====================================================
- Coverage             53.52%   53.36%   -0.16%     
+ Complexity             8028     8010      -18     
====================================================
  Files                   830      830              
  Lines                 48825    48864      +39     
  Branches               5355     5358       +3     
====================================================
- Hits                  26132    26078      -54     
- Misses                20649    20732      +83     
- Partials               2044     2054      +10     
Impacted Files Coverage Δ
...rc/main/java/org/tron/core/vm/program/Program.java 63.40% <0.00%> (+0.25%) ⬆️
common/src/main/java/org/tron/core/Constant.java 50.00% <ø> (ø)
framework/src/main/java/org/tron/core/Wallet.java 18.21% <0.00%> (-0.03%) ⬇️
...rc/main/java/org/tron/core/utils/ProposalUtil.java 34.13% <33.33%> (-0.25%) ⬇️
...ava/org/tron/common/parameter/CommonParameter.java 55.87% <50.00%> (-0.04%) ⬇️
.../src/main/java/org/tron/core/config/args/Args.java 59.81% <66.66%> (-1.81%) ⬇️
...rc/main/java/org/tron/core/vm/config/VMConfig.java 91.66% <75.00%> (-1.20%) ⬇️
...ain/java/org/tron/core/vm/config/ConfigLoader.java 87.50% <100.00%> (+1.13%) ⬆️
...va/org/tron/core/store/DynamicPropertiesStore.java 97.26% <100.00%> (+0.02%) ⬆️
.../java/org/tron/core/consensus/ProposalService.java 92.50% <100.00%> (+0.14%) ⬆️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@CodeNinjaEvan CodeNinjaEvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants