Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): optimize the auto-stop logic #4858

Merged

Conversation

halibobo1205
Copy link
Contributor

What does this PR do?
1. print an error and exit when the parameter is illegal
2. print an error and exit when more than one parameter is set
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 force-pushed the feat/auto_stop_opt branch 2 times, most recently from 5edc6b2 to a4373c2 Compare December 20, 2022 11:05
@codecov-commenter
Copy link

Codecov Report

Merging #4858 (a4373c2) into release_v4.7.0 (eb0065c) will decrease coverage by 0.18%.
The diff coverage is 37.03%.

@@                 Coverage Diff                  @@
##             release_v4.7.0    #4858      +/-   ##
====================================================
- Coverage             53.52%   53.33%   -0.19%     
+ Complexity             8028     8006      -22     
====================================================
  Files                   830      830              
  Lines                 48825    48862      +37     
  Branches               5355     5363       +8     
====================================================
- Hits                  26132    26059      -73     
- Misses                20649    20746      +97     
- Partials               2044     2057      +13     
Impacted Files Coverage Δ
common/src/main/java/org/tron/core/Constant.java 50.00% <ø> (ø)
...mework/src/main/java/org/tron/core/db/Manager.java 52.59% <27.50%> (-1.90%) ⬇️
...ava/org/tron/common/parameter/CommonParameter.java 55.87% <50.00%> (-0.04%) ⬇️
.../src/main/java/org/tron/core/config/args/Args.java 59.75% <50.00%> (-1.87%) ⬇️
...c/main/java/org/tron/core/net/TronNetDelegate.java 41.26% <66.66%> (+1.92%) ⬆️
...rc/main/java/org/tron/core/net/TronNetService.java 98.48% <100.00%> (+0.02%) ⬆️
...org/tron/core/exception/ItemNotFoundException.java 33.33% <0.00%> (-33.34%) ⬇️
.../main/java/org/tron/core/net/peer/PeerManager.java 16.85% <0.00%> (-20.23%) ⬇️
...src/main/java/org/tron/core/db/PendingManager.java 34.88% <0.00%> (-16.28%) ⬇️
.../java/org/tron/common/setting/RocksDbSettings.java 88.70% <0.00%> (-9.68%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

  1. print an error and exit when the parameter is illegal
  2. print an error and exit when more than one parameter is set
@halibobo1205 halibobo1205 merged commit 1337d45 into tronprotocol:release_v4.7.0 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants