Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sonar #2265

Merged
merged 1 commit into from
May 29, 2019
Merged

fix sonar #2265

merged 1 commit into from
May 29, 2019

Conversation

CodeNinjaEvan
Copy link
Collaborator

What does this PR do?
fix sonar
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2265 into release_3.6 will decrease coverage by 0.08%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release_3.6   #2265      +/-   ##
================================================
- Coverage          42.59%   42.5%   -0.09%     
+ Complexity          4464    4338     -126     
================================================
  Files                541     537       -4     
  Lines              33024   32490     -534     
  Branches            3657    3562      -95     
================================================
- Hits               14067   13811     -256     
+ Misses             17611   17358     -253     
+ Partials            1346    1321      -25
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/tron/core/capsule/ReceiptCapsule.java 71.05% <0%> (-0.38%) 23 <0> (ø)
...main/java/org/tron/common/runtime/RuntimeImpl.java 60.77% <33.33%> (-0.11%) 51 <2> (ø)
...rg/tron/common/net/udp/handler/MessageHandler.java 89.65% <0%> (-10.35%) 7% <0%> (-1%)
...g/tron/common/overlay/discover/DiscoverServer.java 74.13% <0%> (-8.63%) 6% <0%> (-2%)
src/main/java/org/tron/common/utils/ByteArray.java 53.33% <0%> (-3.34%) 15% <0%> (-1%)
src/main/java/org/tron/core/db/Manager.java 44.06% <0%> (-3.28%) 116% <0%> (-105%)
.../java/org/tron/common/overlay/server/SyncPool.java 33.07% <0%> (-0.77%) 12% <0%> (-1%)
...ava/org/tron/core/db/accountstate/TrieService.java
.../accountstate/storetrie/AccountStateStoreTrie.java
...db/accountstate/callback/AccountStateCallBack.java
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541a033...4fcebe2. Read the comment docs.

@tjchern tjchern merged commit 9a4f9f8 into release_3.6 May 29, 2019
@shydesky shydesky deleted the Hotfix/fix_creator_is_null_sonar branch November 13, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants