Feature/triggerConstantContract & clearContractABI #2125

llwslc · 2019-04-12T07:14:11Z

What does this PR do?

To provide a new interface, which bypass ABI checking and triggers the constant contracts at the evm layer.
To provide a new interface, which clear contract ABI.

Why are these changes required?

Developers need to bypass the ABI checking and trigger the constant contract directly.
Developers can delete ABI of existing contracts.

This PR has been tested by:

Unit Tests
Manual Testing

Follow up

Extra details
tronprotocol/TIPs#31
tronprotocol/TIPs#32

…tack

…o tip26_create2

1. Use variable `isStaticCall` instead of `isRootCallConstant` in class `Program` 2. Remove useless constant-check of tx from P2P

# Conflicts: # src/main/java/org/tron/common/runtime/config/VMConfig.java # src/main/java/org/tron/common/runtime/vm/DataWord.java # src/main/java/org/tron/common/runtime/vm/OpCode.java # src/main/java/org/tron/core/Wallet.java # src/main/java/org/tron/core/actuator/ProposalCreateActuator.java # src/main/java/org/tron/core/config/Parameter.java # src/main/java/org/tron/core/db/DynamicPropertiesStore.java # src/main/java/org/tron/core/db/TransactionTrace.java # src/main/java/org/tron/core/witness/ProposalController.java # src/main/protos/core/Tron.proto # src/test/java/org/tron/common/runtime/vm/DataWordTest.java # src/test/java/org/tron/core/actuator/ProposalCreateActuatorTest.java # src/test/java/stest/tron/wallet/common/client/utils/AbiUtil.java

codecov-io · 2019-04-12T10:20:46Z

Codecov Report

Merging #2125 into develop will increase coverage by 0.31%.
The diff coverage is 38.62%.

@@              Coverage Diff              @@
##             develop    #2125      +/-   ##
=============================================
+ Coverage      42.28%   42.59%   +0.31%     
- Complexity      4245     4317      +72     
=============================================
  Files            536      539       +3     
  Lines          32172    32419     +247     
  Branches        3512     3532      +20     
=============================================
+ Hits           13603    13810     +207     
- Misses         17273    17290      +17     
- Partials        1296     1319      +23

Impacted Files	Coverage Δ	Complexity Δ
...java/org/tron/core/capsule/TransactionCapsule.java	`19.32% <0%> (-0.92%)`	`26 <0> (-2)`
...ain/java/org/tron/core/services/RpcApiService.java	`5.54% <0%> (+0.28%)`	`8 <0> (+1)`	⬆️
...org/tron/core/actuator/ProposalCreateActuator.java	`35.71% <0%> (-0.29%)`	`23 <0> (+1)`
src/main/java/org/tron/core/db/Manager.java	`42.15% <0%> (-0.04%)`	`122 <0> (-1)`
...c/main/java/org/tron/core/db/TransactionTrace.java	`44.64% <0%> (-4.38%)`	`18 <0> (ø)`
...ron/core/services/http/FullNodeHttpApiService.java	`3.19% <0%> (-0.07%)`	`2 <0> (ø)`
...g/tron/common/runtime/vm/PrecompiledContracts.java	`7.19% <0%> (+0.01%)`	`2 <0> (ø)`	⬇️
...java/org/tron/core/witness/ProposalController.java	`44.53% <0%> (-0.77%)`	`14 <0> (ø)`
...n/java/org/tron/core/actuator/ActuatorFactory.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...in/java/org/tron/core/capsule/ContractCapsule.java	`71.42% <100%> (-4.33%)`	`12 <1> (+1)`
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ae0ab...e731b68. Read the comment docs.

# Conflicts: # src/main/java/org/tron/core/Wallet.java # src/main/java/org/tron/core/actuator/ProposalCreateActuator.java # src/main/java/org/tron/core/config/Parameter.java

ithinker1991

LGTM

BlueHoopor · 2019-05-24T09:11:37Z

refer to #2242

ithinker1991 and others added 30 commits March 18, 2019 18:15

Add opcode: SHL,SHR,SAR

fd9852c

Add CREATE2

5ec51d5

Create contract save returnH value

15b8649

Add dataword negate method

5164c05

Fix DataWord bug

cefa536

Fix sender

078af92

Add bytes coder

a78dfc5

Add create2 opcode unit test

bde8009

Remove debug msg

6b18e28

Add opcode: SHL,SHR,SAR

a5d4069

Add bitwise shift instructions

4bf766e

Add shift test

417297f

Fix shiftRightSigned bug

ec2e7ae

Eliminate hidden dangers of DataWord where ZERO is pushed in to the s…

b0c742c

…tack

Fix unsafe method

9ead847

Merge branch 'tip29_bitwise_shifting' into tip26_create2

5c5ec2e

Add Zero DataWord

f7673d8

Merge branch 'tip29_bitwise_shifting' into tip26_create2

b0c8138

Fix bug

1057095

Zero DataWord can be rightValue

b9348c8

Merge branch 'tip29_bitwise_shifting' into tip26_create2

e7f58d1

Add repeat create2 test case

9aa288b

refactor

0b9faef

Polish code

7895022

refactor

7aaac97

Merge branch 'tip26_create2' of github.com:tronprotocol/java-tron int…

f0e1ae8

…o tip26_create2

Rename final var

30c55b7

refactor: add ALLOW_TVM_CONSTANTINOPLE proposal

17b0ba3

refactor: filter the decision by allowTvmConstantinople proposal

2acc81b

Fix salt value

c4ce3cb

CodeNinjaEvan and others added 19 commits March 25, 2019 12:16

fix: ProposalCreateActuatorTest

5ce3d71

Merge branch 'feature/bitwise_shifting' into feature/create2

647c7c7

Add constantinople hard fork

bc185cd

Test add hard fork

05c64a8

Remove of method of DataWord

f474192

Add fork logic

41db264

Add init_code hash

9aa7df8

add opcode EXTCODEHASH

0211005

add extcodehash fork logic

5a5bd29

test case DataWord to BigInteger method typo

77a67cb

Fix code style of ABIUtil.java

2259037

change return of getCodeHashAt

512170b

add triggerConstantContract

e3062f3

refactor constant check

53d322d

1. Use variable `isStaticCall` instead of `isRootCallConstant` in class `Program` 2. Remove useless constant-check of tx from P2P

add constant_check of tx from P2P

dec86a1

merge clear abi feature

70574d6

add clearABIContractActuatorTest

3443bbb

fix enum ChainParameters

fdfddfc

ithinker1991 and others added 5 commits April 15, 2019 15:07

reorder the parameters of generateContractAddress2 method

69afe39

add triggerConstantContract clearABI http api

9f25a23

add hard fork

88d459c

Merge branch 'develop' into feature/trigger_constant_contract

73dcfa7

# Conflicts: # src/main/java/org/tron/core/Wallet.java # src/main/java/org/tron/core/actuator/ProposalCreateActuator.java # src/main/java/org/tron/core/config/Parameter.java

add clearABI test hard fork

e731b68

ithinker1991 approved these changes Apr 16, 2019

View reviewed changes

ithinker1991 merged commit b1cbad5 into develop Apr 16, 2019

llwslc changed the title ~~Feature/trigger constant contract~~ Feature/triggerConstantContract & clearContractABI May 31, 2019

ithinker1991 mentioned this pull request May 31, 2019

release_3.6 to master #2233

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/triggerConstantContract & clearContractABI #2125

Feature/triggerConstantContract & clearContractABI #2125

llwslc commented Apr 12, 2019 •

edited

Loading

codecov-io commented Apr 12, 2019 •

edited

Loading

ithinker1991 left a comment

BlueHoopor commented May 24, 2019

Feature/triggerConstantContract & clearContractABI #2125

Feature/triggerConstantContract & clearContractABI #2125

Conversation

llwslc commented Apr 12, 2019 • edited Loading

codecov-io commented Apr 12, 2019 • edited Loading

Codecov Report

ithinker1991 left a comment

Choose a reason for hiding this comment

BlueHoopor commented May 24, 2019

llwslc commented Apr 12, 2019 •

edited

Loading

codecov-io commented Apr 12, 2019 •

edited

Loading