Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if config args: merge with json file params. #24

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

tavdog
Copy link
Member

@tavdog tavdog commented Mar 4, 2025

No description provided.

Copy link

Warning

Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting /gemini summary.

@IngmarStein
Copy link
Member

/gemini summary

Copy link

Summary of Changes

This pull request modifies the render function in cmd/render.go to handle configuration arguments passed via the command line. Specifically, it ensures that parameters provided as key-value pairs (e.g., key=value) are correctly parsed and added to the configuration. The change involves adjusting the indexing within the strings.Join function to properly handle values that might contain additional = characters.

Highlights

  • Configuration Handling: The pull request updates how configuration parameters are parsed from the command line arguments.
  • Bug Fix: Addresses an issue where values containing = were not correctly parsed.

Changelog

  • cmd/render.go
    • Modified the parameter parsing logic to correctly handle values containing '=' characters.
    • Removed redundant logging of json config, and moved logging statement to the end of the config parsing to log all config values.

Activity

  • Gemini initially failed to create a summary due to high traffic.
  • IngmarStein requested a summary using the /gemini summary command.

@tavdog tavdog merged commit 21e2113 into main Mar 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants