Fix more clang tidy findings #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 18, 2020 10:03
A vim swap file was accidentially committed at some time in the past. This commit removes it and adds *.swp to the git ignore file so that this can't happen again in the future
Spotted by the clang-tidy-9 static checker. Also removed a few casts because void* implicitly converts to any other pointer type without a cast. Unfortunately, a few casts (e. g. size_t to int) needed to be added in order to make the static checker happy; these, however, point to possible problems and should be addressed in the future.
clang-tidy-9, in accordance with the CERT standard, doesn't like atoi, for good reasons.
7dabc3c to
d6180fd
Compare
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still cleaning up the mDNS source code according to findings of the clang-tidy-9 static checker. This time we're removing narrowing conversions, unneeded casts, and an unsafe string->int conversion.
Integer types are still being handled in a sloppy way in some places, e. g. by storing a size_t in an int, which may not necessarily fit. I added casts in a few places which both silence the static checker and point out the possible overruns. In completely clean code, most of these casts should not be necessary. No functional changes were introduced.
Also, a vim swap file was committed by accident. May well have been me in a previous commit, sorry :-/ Removed it and added *.swp to the git ignore file.