Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid continuously duplicate commands in history #25

Merged
merged 1 commit into from
May 3, 2019

Conversation

abitmore
Copy link
Contributor

@abitmore abitmore commented May 3, 2019

When adding a command to history, if CONFIG_UNIQUE_HISTORY is defined, always compare current command with the last entry in history.

Steps to reproduce the bug:

  1. input a command A, press enter
  2. input a command B, press enter
  3. press up arrow, see B
  4. press up arrow, see A
  5. press down arrow, see B, press enter
  6. press up arrow, see B,
  7. press up arrow, still see B, this behavior is not expected.

When adding a command to history, if CONFIG_UNIQUE_HISTORY is defined, always compare current command with the last entry in history.
@troglobit
Copy link
Owner

Great work, I've been hunting for this bug a few times over the years!

@troglobit troglobit merged commit 448a3da into troglobit:master May 3, 2019
@troglobit
Copy link
Owner

@abitmore Do you have any more bug fixes planned for editline? I'm planning a v1.16.1 release in the very near term, so just curious.

@abitmore abitmore deleted the patch-1 branch May 3, 2019 17:25
@abitmore
Copy link
Contributor Author

abitmore commented May 4, 2019

I'm investigating some issues related to BitShares (link), not sure whether need to modify editline to fix them, nor how much time I will need. Wish this info helps.

@troglobit
Copy link
Owner

@abitmore I understand, thank you and good luck! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants