-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GPUs actually usable #689
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 70.53% 70.43% -0.10%
==========================================
Files 96 96
Lines 5976 5974 -2
==========================================
- Hits 4215 4208 -7
- Misses 1761 1766 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…iParticles.jl into ef/more-gpu-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few selected examples should be executed for GPU compatibility so that more of the features are checked.
We would need a self-hosted runner with a GPU to test any of this. |
6d9c0e5
to
2a07ce2
Compare
Depends on trixi-framework/PointNeighbors.jl#90 and trixi-framework/TrixiBase.jl#35.
This PR contains the following changes:
Float32
(and therefore on Apple GPUs that don't support double precision).I added a new macroMoved to Add macrotrixi_include_changeprecision(Float32, example_file)
to conveniently change allFloat64
literals in an example file toFloat32
, which is enough to make the whole simulation run with single precision (that's how we designed the code).trixi_include_changeprecision
to make a double precision elixir run with single precision TrixiBase.jl#35.Find the rendered docs for this PR here:
https://trixi-framework.github.io/TrixiParticles.jl/previews/PR689/