Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GPUs actually usable #689

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Make GPUs actually usable #689

wants to merge 29 commits into from

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Dec 23, 2024

Depends on trixi-framework/PointNeighbors.jl#90 and trixi-framework/TrixiBase.jl#35.

This PR contains the following changes:

Find the rendered docs for this PR here:
https://trixi-framework.github.io/TrixiParticles.jl/previews/PR689/

@efaulhaber efaulhaber self-assigned this Dec 24, 2024
@efaulhaber efaulhaber added the gpu label Jan 14, 2025
@efaulhaber efaulhaber marked this pull request as ready for review January 29, 2025 08:10
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.43%. Comparing base (6d04215) to head (c7abe36).

Files with missing lines Patch % Lines
src/visualization/recipes_plots.jl 0.00% 13 Missing ⚠️
...chemes/boundary/dummy_particles/dummy_particles.jl 60.00% 2 Missing ⚠️
...chemes/solid/total_lagrangian_sph/penalty_force.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   70.53%   70.43%   -0.10%     
==========================================
  Files          96       96              
  Lines        5976     5974       -2     
==========================================
- Hits         4215     4208       -7     
- Misses       1761     1766       +5     
Flag Coverage Δ
unit 70.43% <42.85%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber requested review from LasNikas and svchb January 30, 2025 09:16
Copy link
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few selected examples should be executed for GPU compatibility so that more of the features are checked.

@efaulhaber
Copy link
Member Author

A few selected examples should be executed for GPU compatibility so that more of the features are checked.

We would need a self-hosted runner with a GPU to test any of this.

@efaulhaber efaulhaber requested a review from svchb February 20, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants