-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix plotting 1d function #2271
fix plotting 1d function #2271
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 490 490
Lines 39491 39491
=======================================
Hits 38257 38257
Misses 1234 1234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We make one dummy call to
func
to obtain the number of variables. We should pass a one-entrySVector
forx
instead of a scalar since we also passSVector
s later when getting the plotting data. This is to be consistent when calling initial conditions, where we also always pass the spatial variable as a vector (in 1D a vector with one element). Some initial conditions from Trixi.jl are compatible to work with both real values and vectors, but not all. Therefore, passing only a real value will not work with all predefined initial conditions.