-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERK2 constructor consistence #2184
PERK2 constructor consistence #2184
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 490 490
Lines 39462 39463 +1
=======================================
+ Hits 38228 38229 +1
Misses 1234 1234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM and can be merged when we're ready for a breaking release. Thanks! |
I converted this to draft mode so that nobody accidentally merges this breaking PR. |
abae9a0
This makes
bS
andcS
keyword arguments for allPairedExplicitRK2
constructors.