Fix svelte packages being required all the time #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayusharma
approved these changes
Dec 6, 2024
smashchatsdev
pushed a commit
to smashchats/smash-node-lib
that referenced
this pull request
Dec 6, 2024
git revert 0ea542c issue with svelte should be solved in 5.1.0 but isnt trivago/prettier-plugin-sort-imports#327 no urge to upgrade adding a GH workflow stage to run build checks in order to catch this sort of issues in CI
|
I still get this error on 5.1.0 |
|
Hello, I am using the @trivago/prettier-plugin-sort-imports package version ^5.1.0. However, I am still encountering the following error: |
|
Same here |
pckilgore
reviewed
Dec 8, 2024
| @@ -84,7 +86,7 @@ module.exports = { | |||
| preprocess: vuePreprocessor, | |||
| }, | |||
| svelte: { | |||
| ...svelteParsers.svelte, | |||
| ...svelteParsers.parsers.svelte, | |||
There was a problem hiding this comment.
The only branch of createSvelteParsers where parsers is defined is the successful try case.
This will cause a type error for anyone without prettier-plugin-svelte.
There was a problem hiding this comment.
The fix is coming soon and I should never release anything on a Friday!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve the issue in v5 that Svelte related packages were required for all project types.