-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add convenience HighlightLines::from_state
constructor
#569
refactor: add convenience HighlightLines::from_state
constructor
#569
Conversation
dba6d94
to
bfbc619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would prefer a test that demonstrates how to use this new function, that also serves as a regression test.
But I'm fine you merging this as-is Keith if you are confident this is needed and the right approach.
I'm confident that this is needed and the right approach. I also agree that a test would be nice 🙂 |
Thank you both for your input 🙏🏻 I added a Didn't add the test as an example to the method's documentation but can do so if you think it's a good idea. Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the test. Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, thanks.
I'd like to ask trishume to allow CI to run without manual action, but that's a later thing.
Thanks for the quick feedback 🙏 |
This PR adds a convenience method to easily be able to reinstantiate a
HighlightLines
object from a previous state the user might have cached.