Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android 29 add and connect #110

Closed
wants to merge 3 commits into from
Closed

Fix android 29 add and connect #110

wants to merge 3 commits into from

Conversation

gfavalessa-spwr
Copy link

This is build on top of #104 adding just enough fixes to makee "connect" work.

Viggo Chavine and others added 3 commits June 12, 2020 14:35
@ViggoChavine
Add support for API level 29
e617350
@favalex
fixes for v29
6e553e8 
In API 29 connection happens in the add() method. Consequences:

- return from the callback with success or error depending on the availability
  of the requested network
- exit early in connect(), there is nothing left to do
@favalex
remove NET_CAPABILITY_INTERNET from the request
1ca3d1c 
Or the AP won't be found.

Following https://developer.android.com/reference/android/net/wifi/WifiNetworkSpecifier.Builder#build()

and https://stackoverflow.com/questions/58769623/android-10-api-29-how-to-connect-the-phone-to-a-configured-network
@gfavalessa-spwr gfavalessa-spwr marked this pull request as draft August 11, 2020 15:59
@gfavalessa-spwr gfavalessa-spwr deleted the fix/android-29-add-and-connect branch August 11, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfavalessa-spwr @favalex