Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TRUNCATE TABLE statement #8932

Merged
merged 2 commits into from
Nov 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.trino.execution;

import com.google.common.util.concurrent.ListenableFuture;
import io.trino.Session;
import io.trino.execution.warnings.WarningCollector;
import io.trino.metadata.Metadata;
import io.trino.metadata.QualifiedObjectName;
import io.trino.metadata.TableHandle;
import io.trino.security.AccessControl;
import io.trino.spi.connector.ConnectorMaterializedViewDefinition;
import io.trino.spi.connector.ConnectorViewDefinition;
import io.trino.sql.tree.Expression;
import io.trino.sql.tree.TruncateTable;
import io.trino.transaction.TransactionManager;

import java.util.List;
import java.util.Optional;

import static com.google.common.util.concurrent.Futures.immediateFuture;
import static io.trino.metadata.MetadataUtil.createQualifiedObjectName;
import static io.trino.spi.StandardErrorCode.NOT_SUPPORTED;
import static io.trino.spi.StandardErrorCode.TABLE_NOT_FOUND;
import static io.trino.sql.analyzer.SemanticExceptions.semanticException;

public class TruncateTableTask
implements DataDefinitionTask<TruncateTable>
{
@Override
public String getName()
{
return "TRUNCATE TABLE";
}

@Override
public ListenableFuture<Void> execute(
TruncateTable statement,
TransactionManager transactionManager,
Metadata metadata,
AccessControl accessControl,
QueryStateMachine stateMachine,
List<Expression> parameters,
WarningCollector warningCollector)
{
Session session = stateMachine.getSession();
QualifiedObjectName tableName = createQualifiedObjectName(session, statement, statement.getTableName());

Optional<ConnectorMaterializedViewDefinition> materializedView = metadata.getMaterializedView(session, tableName);
if (materializedView.isPresent()) {
throw semanticException(NOT_SUPPORTED, statement, "Cannot truncate a materialized view");
}

Optional<ConnectorViewDefinition> view = metadata.getView(session, tableName);
if (view.isPresent()) {
throw semanticException(NOT_SUPPORTED, statement, "Cannot truncate a view");
}

Optional<TableHandle> tableHandle = metadata.getTableHandle(session, tableName);
if (tableHandle.isEmpty()) {
throw semanticException(TABLE_NOT_FOUND, statement, "Table '%s' does not exist", tableName);
}

accessControl.checkCanTruncateTable(session.toSecurityContext(), tableName);

metadata.truncateTable(session, tableHandle.get());

return immediateFuture(null);
}
}
5 changes: 5 additions & 0 deletions core/trino-main/src/main/java/io/trino/metadata/Metadata.java
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@ Optional<TableExecuteHandle> getTableHandleForExecute(
*/
void dropTable(Session session, TableHandle tableHandle);

/**
* Truncates the specified table
*/
void truncateTable(Session session, TableHandle tableHandle);

Optional<NewTableLayout> getNewTableLayout(Session session, String catalogName, ConnectorTableMetadata tableMetadata);

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,14 @@ public void dropTable(Session session, TableHandle tableHandle)
metadata.dropTable(session.toConnectorSession(catalogName), tableHandle.getConnectorHandle());
}

@Override
public void truncateTable(Session session, TableHandle tableHandle)
{
CatalogName catalogName = tableHandle.getCatalogName();
ConnectorMetadata metadata = getMetadataForWrite(session, catalogName);
metadata.truncateTable(session.toConnectorSession(catalogName), tableHandle.getConnectorHandle());
}

@Override
public Optional<NewTableLayout> getInsertLayout(Session session, TableHandle table)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,13 @@ public interface AccessControl
*/
void checkCanDeleteFromTable(SecurityContext context, QualifiedObjectName tableName);

/**
* Check if identity is allowed to truncate the specified table.
*
* @throws AccessDeniedException if not allowed
*/
void checkCanTruncateTable(SecurityContext context, QualifiedObjectName tableName);

/**
* Check if identity is allowed to update the specified table.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,19 @@ public void checkCanDeleteFromTable(SecurityContext securityContext, QualifiedOb
catalogAuthorizationCheck(tableName.getCatalogName(), securityContext, (control, context) -> control.checkCanDeleteFromTable(context, tableName.asSchemaTableName()));
}

@Override
public void checkCanTruncateTable(SecurityContext securityContext, QualifiedObjectName tableName)
{
requireNonNull(securityContext, "securityContext is null");
requireNonNull(tableName, "tableName is null");

checkCanAccessCatalog(securityContext, tableName.getCatalogName());

systemAuthorizationCheck(control -> control.checkCanTruncateTable(securityContext.toSystemSecurityContext(), tableName.asCatalogSchemaTableName()));

catalogAuthorizationCheck(tableName.getCatalogName(), securityContext, (control, context) -> control.checkCanTruncateTable(context, tableName.asSchemaTableName()));
}

@Override
public void checkCanUpdateTableColumns(SecurityContext securityContext, QualifiedObjectName tableName, Set<String> updatedColumnNames)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,11 @@ public void checkCanDeleteFromTable(SecurityContext context, QualifiedObjectName
{
}

@Override
public void checkCanTruncateTable(SecurityContext context, QualifiedObjectName tableName)
{
}

@Override
public void checkCanUpdateTableColumns(SecurityContext context, QualifiedObjectName tableName, Set<String> updatedColumnNames)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
import static io.trino.spi.security.AccessDeniedException.denyShowRoles;
import static io.trino.spi.security.AccessDeniedException.denyShowSchemas;
import static io.trino.spi.security.AccessDeniedException.denyShowTables;
import static io.trino.spi.security.AccessDeniedException.denyTruncateTable;
import static io.trino.spi.security.AccessDeniedException.denyUpdateTableColumns;
import static io.trino.spi.security.AccessDeniedException.denyViewQuery;
import static io.trino.spi.security.AccessDeniedException.denyWriteSystemInformationAccess;
Expand Down Expand Up @@ -293,6 +294,12 @@ public void checkCanDeleteFromTable(SecurityContext context, QualifiedObjectName
denyDeleteTable(tableName.toString());
}

@Override
public void checkCanTruncateTable(SecurityContext context, QualifiedObjectName tableName)
{
denyTruncateTable(tableName.toString());
}

@Override
public void checkCanUpdateTableColumns(SecurityContext context, QualifiedObjectName tableName, Set<String> updatedColumnNames)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,12 @@ public void checkCanDropTable(SecurityContext context, QualifiedObjectName table
delegate().checkCanDropTable(context, tableName);
}

@Override
public void checkCanTruncateTable(SecurityContext context, QualifiedObjectName tableName)
{
delegate().checkCanTruncateTable(context, tableName);
}

@Override
public void checkCanRenameTable(SecurityContext context, QualifiedObjectName tableName, QualifiedObjectName newTableName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ public void checkCanDropTable(ConnectorSecurityContext context, SchemaTableName
accessControl.checkCanDropTable(securityContext, getQualifiedObjectName(tableName));
}

@Override
public void checkCanTruncateTable(ConnectorSecurityContext context, SchemaTableName tableName)
{
checkArgument(context == null, "context must be null");
accessControl.checkCanTruncateTable(securityContext, getQualifiedObjectName(tableName));
}

@Override
public void checkCanRenameTable(ConnectorSecurityContext context, SchemaTableName tableName, SchemaTableName newTableName)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import io.trino.execution.SetViewAuthorizationTask;
import io.trino.execution.SqlQueryExecution.SqlQueryExecutionFactory;
import io.trino.execution.StartTransactionTask;
import io.trino.execution.TruncateTableTask;
import io.trino.execution.UseTask;
import io.trino.sql.tree.AddColumn;
import io.trino.sql.tree.Call;
Expand Down Expand Up @@ -98,6 +99,7 @@
import io.trino.sql.tree.SetViewAuthorization;
import io.trino.sql.tree.StartTransaction;
import io.trino.sql.tree.Statement;
import io.trino.sql.tree.TruncateTable;
import io.trino.sql.tree.Use;

import static com.google.common.base.Preconditions.checkArgument;
Expand Down Expand Up @@ -133,6 +135,7 @@ public void configure(Binder binder)
bindDataDefinitionTask(binder, executionBinder, DropSchema.class, DropSchemaTask.class);
bindDataDefinitionTask(binder, executionBinder, DropTable.class, DropTableTask.class);
bindDataDefinitionTask(binder, executionBinder, DropView.class, DropViewTask.class);
bindDataDefinitionTask(binder, executionBinder, TruncateTable.class, TruncateTableTask.class);
bindDataDefinitionTask(binder, executionBinder, CreateMaterializedView.class, CreateMaterializedViewTask.class);
bindDataDefinitionTask(binder, executionBinder, DropMaterializedView.class, DropMaterializedViewTask.class);
bindDataDefinitionTask(binder, executionBinder, Grant.class, GrantTask.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@
import io.trino.sql.tree.Table;
import io.trino.sql.tree.TableExecute;
import io.trino.sql.tree.TableSubquery;
import io.trino.sql.tree.TruncateTable;
import io.trino.sql.tree.Union;
import io.trino.sql.tree.Unnest;
import io.trino.sql.tree.Update;
Expand Down Expand Up @@ -956,6 +957,12 @@ protected Scope visitCallArgument(CallArgument node, Optional<Scope> scope)
return createAndAssignScope(node, scope);
}

@Override
protected Scope visitTruncateTable(TruncateTable node, Optional<Scope> scope)
{
return createAndAssignScope(node, scope);
}

@Override
protected Scope visitDropTable(DropTable node, Optional<Scope> scope)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
import io.trino.execution.TableExecuteContextManager;
import io.trino.execution.TaskManagerConfig;
import io.trino.execution.TaskSource;
import io.trino.execution.TruncateTableTask;
import io.trino.execution.resourcegroups.NoOpResourceGroupManager;
import io.trino.execution.scheduler.NodeScheduler;
import io.trino.execution.scheduler.NodeSchedulerConfig;
Expand Down Expand Up @@ -192,6 +193,7 @@
import io.trino.sql.tree.SetTimeZone;
import io.trino.sql.tree.StartTransaction;
import io.trino.sql.tree.Statement;
import io.trino.sql.tree.TruncateTable;
import io.trino.testing.PageConsumerOperator.PageConsumerOutputFactory;
import io.trino.transaction.InMemoryTransactionManager;
import io.trino.transaction.TransactionId;
Expand Down Expand Up @@ -461,6 +463,7 @@ private LocalQueryRunner(
.put(CreateView.class, new CreateViewTask(sqlParser, groupProvider, statsCalculator))
.put(DropTable.class, new DropTableTask())
.put(DropView.class, new DropViewTask())
.put(TruncateTable.class, new TruncateTableTask())
.put(RenameColumn.class, new RenameColumnTask())
.put(RenameMaterializedView.class, new RenameMaterializedViewTask())
.put(RenameTable.class, new RenameTableTask())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
import static io.trino.spi.security.AccessDeniedException.denySetUser;
import static io.trino.spi.security.AccessDeniedException.denyShowColumns;
import static io.trino.spi.security.AccessDeniedException.denyShowCreateTable;
import static io.trino.spi.security.AccessDeniedException.denyTruncateTable;
import static io.trino.spi.security.AccessDeniedException.denyUpdateTableColumns;
import static io.trino.spi.security.AccessDeniedException.denyViewQuery;
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.ADD_COLUMN;
Expand Down Expand Up @@ -112,6 +113,7 @@
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.SET_USER;
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.SHOW_COLUMNS;
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.SHOW_CREATE_TABLE;
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.TRUNCATE_TABLE;
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.UPDATE_TABLE;
import static io.trino.testing.TestingAccessControlManager.TestingPrivilegeType.VIEW_QUERY;
import static java.util.Objects.requireNonNull;
Expand Down Expand Up @@ -458,6 +460,17 @@ public void checkCanDeleteFromTable(SecurityContext context, QualifiedObjectName
}
}

@Override
public void checkCanTruncateTable(SecurityContext context, QualifiedObjectName tableName)
{
if (shouldDenyPrivilege(context.getIdentity().getUser(), tableName.getObjectName(), TRUNCATE_TABLE)) {
denyTruncateTable(tableName.toString());
}
if (denyPrivileges.isEmpty()) {
super.checkCanTruncateTable(context, tableName);
}
}

@Override
public void checkCanUpdateTableColumns(SecurityContext context, QualifiedObjectName tableName, Set<String> updatedColumnNames)
{
Expand Down Expand Up @@ -687,7 +700,7 @@ public enum TestingPrivilegeType
EXECUTE_QUERY, VIEW_QUERY, KILL_QUERY,
EXECUTE_FUNCTION,
CREATE_SCHEMA, DROP_SCHEMA, RENAME_SCHEMA,
SHOW_CREATE_TABLE, CREATE_TABLE, DROP_TABLE, RENAME_TABLE, COMMENT_TABLE, COMMENT_COLUMN, INSERT_TABLE, DELETE_TABLE, UPDATE_TABLE, SET_TABLE_PROPERTIES, SHOW_COLUMNS,
SHOW_CREATE_TABLE, CREATE_TABLE, DROP_TABLE, RENAME_TABLE, COMMENT_TABLE, COMMENT_COLUMN, INSERT_TABLE, DELETE_TABLE, UPDATE_TABLE, TRUNCATE_TABLE, SET_TABLE_PROPERTIES, SHOW_COLUMNS,
ADD_COLUMN, DROP_COLUMN, RENAME_COLUMN, SELECT_COLUMN,
CREATE_VIEW, RENAME_VIEW, DROP_VIEW, CREATE_VIEW_WITH_SELECT_COLUMNS,
CREATE_MATERIALIZED_VIEW, REFRESH_MATERIALIZED_VIEW, DROP_MATERIALIZED_VIEW, RENAME_MATERIALIZED_VIEW,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import io.trino.sql.tree.StartTransaction;
import io.trino.sql.tree.Statement;
import io.trino.sql.tree.TableExecute;
import io.trino.sql.tree.TruncateTable;
import io.trino.sql.tree.Update;
import io.trino.sql.tree.Use;

Expand Down Expand Up @@ -141,6 +142,7 @@ private StatementUtils() {}
.put(DropSchema.class, DATA_DEFINITION)
.put(DropTable.class, DATA_DEFINITION)
.put(DropView.class, DATA_DEFINITION)
.put(TruncateTable.class, DATA_DEFINITION)
.put(Grant.class, DATA_DEFINITION)
.put(GrantRoles.class, DATA_DEFINITION)
.put(Prepare.class, DATA_DEFINITION)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,12 @@ public void dropTable(Session session, TableHandle tableHandle)
throw new UnsupportedOperationException();
}

@Override
public void truncateTable(Session session, TableHandle tableHandle)
{
throw new UnsupportedOperationException();
}

@Override
public Optional<NewTableLayout> getNewTableLayout(Session session, String catalogName, ConnectorTableMetadata tableMetadata)
{
Expand Down
Loading