-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert range predicates to discrete set in Redshift #23417
Convert range predicates to discrete set in Redshift #23417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add test in TestRedshiftConnectorTest which verifies that when query has a range predicate, the domain pushed into table scan is a discrete values list.
plugin/trino-redshift/src/main/java/io/trino/plugin/redshift/RedshiftClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-redshift/src/main/java/io/trino/plugin/redshift/RedshiftClient.java
Show resolved
Hide resolved
Note that TestRedshiftConnectorTest doesn't run in this repository unless updating pom.xml in Redshift connector. trino/plugin/trino-redshift/pom.xml Lines 262 to 265 in 1ef89d2
|
8781c72
to
4b3b7bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, can you check if the redshift test actually ran and passed on CI ?
Running CI on #23598 |
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/PredicatePushdownController.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/PredicatePushdownController.java
Outdated
Show resolved
Hide resolved
03ef4c3
to
d32c1c4
Compare
Updated to fix CI failures reported at https://github.com/trinodb/trino/actions/runs/11081955893/job/30794374722?pr=23598 |
Updated the mirror PR: #23598 |
only |
d32c1c4
to
ba0abf1
Compare
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/PredicatePushdownController.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/PredicatePushdownController.java
Outdated
Show resolved
Hide resolved
ba0abf1
to
4e63d24
Compare
4e63d24
to
b7109b5
Compare
Description
Redshift performs better for IN clause queries compared to range queries. PR aims to change the range queries to IN clause where applicable for the possible performance improvement.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: