Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify work processor adapters #22771

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Jul 23, 2024

No description provided.

@sopel39 sopel39 added the no-release-notes This pull request does not require release notes entry label Jul 23, 2024
@sopel39 sopel39 requested a review from raunaqmorarka July 23, 2024 14:12
@cla-bot cla-bot bot added the cla-signed label Jul 23, 2024
sopel39 added 2 commits July 23, 2024 16:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This makes it less confusing for reader whether single
or multiple splits will be provided.
@sopel39 sopel39 force-pushed the ks/work_proc_simplify branch from 581c776 to 7e7a706 Compare July 23, 2024 14:22
@wendigo
Copy link
Contributor

wendigo commented Jul 23, 2024

Tests failure are related

@sopel39 sopel39 force-pushed the ks/work_proc_simplify branch from 7e7a706 to 4b4ccf2 Compare July 23, 2024 22:26
sopel39 added 3 commits July 24, 2024 11:02
This commit simplifies hierarchy of WorkProcessorOperator
adapters. It also simplifies join implementation.
@sopel39 sopel39 force-pushed the ks/work_proc_simplify branch from 4b4ccf2 to ba5921b Compare July 24, 2024 09:10
@sopel39 sopel39 requested a review from wendigo July 24, 2024 09:26
@wendigo
Copy link
Contributor

wendigo commented Jul 24, 2024

@sopel39 ship it!

@sopel39 sopel39 merged commit b5bfd11 into trinodb:master Jul 24, 2024
99 checks passed
@sopel39 sopel39 deleted the ks/work_proc_simplify branch July 24, 2024 10:45
@github-actions github-actions bot added this to the 453 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

None yet

3 participants