Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestExtract for interval type #22750

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

attilakreiner
Copy link
Member

@attilakreiner attilakreiner commented Jul 22, 2024

Description

This change adds the TestExtract test class for testing the interval type.

Additional context and related issues

Fixes #5627

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented Jul 22, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Jul 22, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@wendigo
Copy link
Contributor

wendigo commented Jul 22, 2024

@attilakreiner have you signed CLA already?

@wendigo wendigo requested a review from martint July 22, 2024 19:26
@martint
Copy link
Member

martint commented Jul 22, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
Copy link

cla-bot bot commented Jul 22, 2024

The cla-bot has been summoned, and re-checked this pull request!

@attilakreiner attilakreiner force-pushed the test-extract-interval branch from da45e4d to b68019b Compare July 23, 2024 05:32
@attilakreiner
Copy link
Member Author

attilakreiner commented Jul 23, 2024

@attilakreiner have you signed CLA already?

@wendigo yep, done now.

@attilakreiner attilakreiner marked this pull request as ready for review July 23, 2024 05:40
@wendigo wendigo merged commit 3daeff4 into trinodb:master Jul 23, 2024
94 of 95 checks passed
@wendigo
Copy link
Contributor

wendigo commented Jul 23, 2024

@attilakreiner thanks! Change merged :)

@github-actions github-actions bot added this to the 453 milestone Jul 23, 2024
@attilakreiner
Copy link
Member Author

@attilakreiner thanks! Change merged :)

Great, thanks! 😎🎉👍

@attilakreiner attilakreiner deleted the test-extract-interval branch July 23, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Implement TestExtract for INTERVAL types
3 participants