Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metastore interface to new module #22718

Merged
merged 20 commits into from
Jul 19, 2024
Merged

Conversation

electrum
Copy link
Member

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@electrum electrum requested a review from dain July 18, 2024 05:43
@cla-bot cla-bot bot added the cla-signed label Jul 18, 2024
@github-actions github-actions bot added hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Jul 18, 2024
@electrum electrum force-pushed the metastore branch 6 times, most recently from d394d04 to 06474ef Compare July 19, 2024 17:32
@electrum electrum merged commit 9c9a3a5 into trinodb:master Jul 19, 2024
114 checks passed
@electrum electrum deleted the metastore branch July 19, 2024 23:37
@github-actions github-actions bot added this to the 453 milestone Jul 19, 2024
@findinpath
Copy link
Contributor

@electrum pls add a description to the PR. This makes it easy for other parties to chime in and provide potentially good feedback.

By skimming the commit messages, this feels like a refactoring - to move metastore related content to lib/trino-metastore.
Being a refactoring there's definitely no business value here to argue about.
However, I'd like to understand the drive of this refactoring.

Are we looking at getting rid of the following dependency from trino-iceberg, trino-delta-lake, trino-hudi:

        <dependency>
            <groupId>io.trino</groupId>
            <artifactId>trino-hive</artifactId>
        </dependency>

?

@electrum electrum changed the title Metastore Move metastore interface to new module Jul 21, 2024
@electrum
Copy link
Member Author

electrum commented Jul 21, 2024

Thanks, the title got lost when I created the PR. This is a cleanup / refactoring that pulls the shared metastore code out of the Hive connector. I'll move the implementations later.

The refactoring forced a cleanup of some unintentional dependencies. It helps a bit with build times and in general it's good to have fewer dependencies on code inside the Hive connector for Iceberg, etc.

I don't have any explicit goal to completely remove the dependency on the Hive connector, and it's not clear yet if that is worthwhile, but this moves us in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector hudi Hudi connector iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

None yet

3 participants