Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility note to FTE exchange manager section #22711

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

michaeleby1
Copy link
Contributor

Description

Add note stating that we do not test all S3-compatible storage systems

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@michaeleby1 michaeleby1 requested a review from mosabua July 17, 2024 17:51
@cla-bot cla-bot bot added the cla-signed label Jul 17, 2024
@github-actions github-actions bot added the docs label Jul 17, 2024
@michaeleby1 michaeleby1 force-pushed the me/fte-exchange-manager-note branch from 98c0498 to 164495c Compare July 17, 2024 19:00
@michaeleby1 michaeleby1 requested a review from mosabua July 17, 2024 19:01
@michaeleby1 michaeleby1 force-pushed the me/fte-exchange-manager-note branch from 164495c to 787c68a Compare July 17, 2024 20:27
@michaeleby1 michaeleby1 requested a review from mosabua July 17, 2024 20:27
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Might be worth considering adding the same thing to https://trino.io/docs/current/object-storage/file-system-s3.html

Would make sense to me.

@mosabua mosabua merged commit e79e532 into trinodb:master Jul 17, 2024
9 checks passed
@mosabua
Copy link
Member

mosabua commented Jul 17, 2024

I updated the commit message fyi @michaeleby1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants