Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add view support for iceberg jdbc catalog #22576

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add view support for iceberg jdbc catalog #22576

merged 1 commit into from
Jul 23, 2024

Conversation

tbaeg
Copy link
Member

@tbaeg tbaeg commented Jul 4, 2024 •
edited by ebyhr
Loading

Description

Add view support for iceberg JDBC catalog.

Additional context and related issues

Iceberg now supports views. The iceberg REST catalog already supports views. This just brings things to parity.

Release notes

# Iceberg
* Add support for views in JDBC catalog. ({issue}`22576`)
* Upgrade `jdbc.schema-version` to `V1` in JDBC catalog. ({issue}`22576`)

@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 4, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tony Baeg.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the iceberg Iceberg connector label Jul 4, 2024
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from 00a500a to 6c74ee5 Compare July 4, 2024 02:35
@cla-bot cla-bot bot added the cla-signed label Jul 4, 2024
@tbaeg tbaeg changed the title WIP: Add view support for iceberg jdbc catalog Add view support for iceberg jdbc catalog Jul 4, 2024
@ebyhr ebyhr self-requested a review July 4, 2024 02:56
@tbaeg tbaeg marked this pull request as draft July 4, 2024 03:02
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from c6697b1 to f8ae19b Compare July 4, 2024 12:29
@tbaeg tbaeg marked this pull request as ready for review July 4, 2024 12:39
@tbaeg tbaeg added the enhancement New feature or request label Jul 4, 2024
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch 2 times, most recently from b41d9e5 to 00d6918 Compare July 4, 2024 13:03
@tbaeg
Copy link
Member Author

tbaeg commented Jul 4, 2024

I don't believe the failure is related.

ebyhr
ebyhr reviewed Jul 9, 2024
View reviewed changes
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from 00d6918 to 1728310 Compare July 10, 2024 02:04
@github-actions github-actions bot added the docs label Jul 10, 2024
@tbaeg
Copy link
Member Author

tbaeg commented Jul 10, 2024

@ebyhr Thanks for the review! Updated the PR relative to your feedback. One thing I did notice is adding the testUnsupportedViewDialect test showed I needed to return discrete tables and views. It made me wonder if views that are not using the supported dialect should even show up in a SHOW TABLES call. This appears to be the behavior for the REST catalog as well. Thoughts?

@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch 2 times, most recently from e5c96ec to 68a8646 Compare July 11, 2024 19:48
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch 3 times, most recently from c421091 to 1cc5772 Compare July 16, 2024 01:07
@tbaeg
Copy link
Member Author

tbaeg commented Jul 19, 2024

Checking in to see if there were any other changes required to get this merged, thanks!

@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 22, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tony Baeg.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Jul 22, 2024
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from 22369c2 to f6a7a5b Compare July 22, 2024 15:19
@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
@ebyhr
Copy link
Member

ebyhr commented Jul 22, 2024

Could you rebase on master to resolve conflicts?

@ebyhr ebyhr added the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label Jul 22, 2024
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from f6a7a5b to 1ab360f Compare July 23, 2024 01:04
@ebyhr
Copy link
Member

ebyhr commented Jul 23, 2024

Could you confirm CI failures?

@tbaeg
Copy link
Member Author

tbaeg commented Jul 23, 2024

Could you confirm CI failures?

Looks one failure related to MissingCasesInEnumSwitch. All enum cases are handled but seems like the plugin just doesn't like the qualified reference. I can remove the qualifer.

Everything else does not seem related.

@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from 1ab360f to 38c34ff Compare July 23, 2024 03:10
@tbaeg tbaeg force-pushed the iceberg-jdbc-catalog branch from 38c34ff to 76abeca Compare July 23, 2024 12:47
@tbaeg
Copy link
Member Author

tbaeg commented Jul 23, 2024

CI failure is not related. @ebyhr

@ebyhr ebyhr merged commit a3de509 into trinodb:master Jul 23, 2024
45 of 46 checks passed
@github-actions github-actions bot added this to the 453 milestone Jul 23, 2024
@mosabua mosabua mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed docs enhancement New feature or request iceberg Iceberg connector stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Milestone
453
Development

Successfully merging this pull request may close these issues.
2 participants
@tbaeg @ebyhr