Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pre-computed hashes by default #19099

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Disable pre-computed hashes by default #19099

merged 1 commit into from
Sep 21, 2023

Conversation

martint
Copy link
Member

@martint martint commented Sep 19, 2023

Pre-computing hashes uses more CPU than the more optimized inline computation within the recently added flat hashtables for aggregations.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2023
@martint martint requested a review from dain September 19, 2023 21:47
@sopel39
Copy link
Member

sopel39 commented Sep 20, 2023

mind automation (I think many tests will fail)

@martint
Copy link
Member Author

martint commented Sep 20, 2023

Yes, I’m aware. Waiting for the CI to issue its verdict so I can go fix all the tests.

@github-actions github-actions bot added tests:hive hive Hive connector labels Sep 20, 2023
@martint martint force-pushed the precomputed-hashes branch 4 times, most recently from fdbdb28 to a8ce619 Compare September 20, 2023 23:07
@github-actions github-actions bot added the delta-lake Delta Lake connector label Sep 20, 2023
@sopel39 sopel39 mentioned this pull request Sep 21, 2023
Closed
@martint martint force-pushed the precomputed-hashes branch 3 times, most recently from d9d8e2a to 2b7d41e Compare September 21, 2023 16:04
@martint
Disable pre-computed hashes
310fb89 
Pre-computing hashes uses more CPU than the more optimized
inline computation within the recently added flat hashtables
for aggregations.
@martint martint merged commit 65ee08a into trinodb:master Sep 21, 2023
@martint martint deleted the precomputed-hashes branch September 21, 2023 21:26
@github-actions github-actions bot added this to the 427 milestone Sep 21, 2023
@colebow colebow mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 approved these changes

@dain dain dain approved these changes

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector
Milestone
427
Development

Successfully merging this pull request may close these issues.
3 participants
@martint @sopel39 @dain